jenkins-bot has submitted this change and it was merged.
Change subject: In group pages, replace subtitle with link to main page
......................................................................
In group pages, replace subtitle with link to main page
These subtitles aren't very helpful because the user would already
know whether the user has read-only permissions or write permissions
by looking at the interface. Since we don't currently have a link to
the main page, replace these with a link to Special:GlobalGroupPermissions
main page, which, IMO, is better.
Change-Id: I956ef5f1935f2a3a7fab7ba8023f7a191142f48f
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/SpecialGlobalGroupPermissions.php
3 files changed, 1 insertion(+), 6 deletions(-)
Approvals:
Alex Monk: Looks good to me, approved
20after4: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/i18n/en.json b/i18n/en.json
index 41c887b..2dcaa1f 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -280,8 +280,6 @@
"centralauth-newgroup-intro": "You can use this form to assign
permissions to a new group.\nNote that a group does not exist unless it has
permissions assigned to it.",
"centralauth-globalgroupperms-newgroupname": "New group name:",
"centralauth-globalgroupperms-creategroup-submit": "Assign permissions",
- "centralauth-editgroup-subtitle": "Editing $1",
- "centralauth-editgroup-subtitle-readonly": "View $1",
"centralauth-editgroup-fieldset": "Permissions for $1",
"centralauth-editgroup-name": "Name of group:",
"centralauth-editgroup-display": "Localised name of group:",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 5c7a7d4..e029a1b 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -296,8 +296,6 @@
"centralauth-newgroup-intro": "Used as intro text.\n\nPreceded by the
fieldset label {{msg-mw|Centralauth-newgroup-legend}}.\n\nFollowed by the
following messages:\n* {{msg-mw|Centralauth-globalgroupperms-newgroupname}}\n*
{{msg-mw|Centralauth-globalgroupperms-creategroup-submit}}",
"centralauth-globalgroupperms-newgroupname": "I think this needs to be
translated as \"Name of the new group\", not as \"New name of the group\". –
[[User:McDutchie|McDutchie]] 16:40, 20 July 2008 (UTC)",
"centralauth-globalgroupperms-creategroup-submit": "Used as label for
the Submit button.\n\nPreceded by
{{msg-mw|Centralauth-globalgroupperms-newgroupname}} and inputbox.",
- "centralauth-editgroup-subtitle": "Subtitle for
Special:GlobalGroupPernissions for users who may edit these
permission.\n\nParameters:\n* $1 - Name of the group\n{{Identical|Editing}}",
- "centralauth-editgroup-subtitle-readonly": "Subtitle for
Special:GlobalGroupPermissions for users without edit right.\nParameters:\n* $1
- Name of the group",
"centralauth-editgroup-fieldset": "Used as fieldset label.
Parameters:\n* $1 - group name",
"centralauth-editgroup-name": "Used as label for \"Global group name\"
input box.",
"centralauth-editgroup-display": "This is a label for a localised group
name.",
diff --git a/includes/specials/SpecialGlobalGroupPermissions.php
b/includes/specials/SpecialGlobalGroupPermissions.php
index 1c95abc..b002e7f 100644
--- a/includes/specials/SpecialGlobalGroupPermissions.php
+++ b/includes/specials/SpecialGlobalGroupPermissions.php
@@ -212,8 +212,7 @@
function buildGroupView( $group ) {
$editable = $this->userCanEdit( $this->getUser() );
- $subtitleMessage = $editable ? 'centralauth-editgroup-subtitle'
: 'centralauth-editgroup-subtitle-readonly';
- $this->getOutput()->setSubtitle( $this->msg( $subtitleMessage,
$group ) );
+ $this->getOutput()->addBacklinkSubtitle( $this->getPageTitle()
);
$fieldsetClass = $editable ? 'mw-centralauth-editgroup' :
'mw-centralauth-editgroup-readonly';
$html = Xml::fieldset( $this->msg(
'centralauth-editgroup-fieldset', $group )->text(), false, array( 'class' =>
$fieldsetClass ) );
--
To view, visit https://gerrit.wikimedia.org/r/289989
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I956ef5f1935f2a3a7fab7ba8023f7a191142f48f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
Gerrit-Reviewer: 20after4 <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
