Hello BBlack,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/294018
to review the following change.
Change subject: Make upload.wikimedia.org cookie-free
......................................................................
Make upload.wikimedia.org cookie-free
Upload cluster requests are never authenticated, and do not included in unique
devices and page view counts (since the upload cluster does not serve page
views). Cookies meant for JavaScript code (like CP and GeoIP) are pointless,
because our JavaScript code can't see them anyway, since it has a different
origin. So keep upload.wikimedia.org cookie-free to avoid pointless network
traffic (remember that cookies are sent both ways) and to improve cacheability.
Bug: T137609
Change-Id: I54ebd0ad11cddb16fec6736901db6a42050efdab
---
M templates/varnish/upload-frontend.inc.vcl.erb
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/18/294018/1
diff --git a/templates/varnish/upload-frontend.inc.vcl.erb
b/templates/varnish/upload-frontend.inc.vcl.erb
index db55c0a..9f31006 100644
--- a/templates/varnish/upload-frontend.inc.vcl.erb
+++ b/templates/varnish/upload-frontend.inc.vcl.erb
@@ -83,6 +83,9 @@
sub cluster_fe_deliver {
call upload_common_deliver;
+ // The upload cluster does not serve page views or authenticated
requests, so keep
+ // it cookie-free to avoid pointless network traffic and to improve
cacheability.
+ unset resp.http.Set-Cookie;
unset resp.http.X-MediaWiki-Original;
if (req.http.X-Content-Disposition == "attachment") {
--
To view, visit https://gerrit.wikimedia.org/r/294018
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54ebd0ad11cddb16fec6736901db6a42050efdab
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
