jenkins-bot has submitted this change and it was merged.
Change subject: Use better way to attach search icon to message table search
......................................................................
Use better way to attach search icon to message table search
With grids we are either wasting space, or more imporantly, the search
icon gets clipped on small screens. Using wrapper div with padding
approach ensures the icon takes a fixed space and the input field
takes the rest.
Change-Id: I98158499594a0bdbb13a236b10667e41d22caac2
---
M resources/css/ext.translate.special.translate.css
M specials/SpecialTranslate.php
2 files changed, 6 insertions(+), 9 deletions(-)
Approvals:
Santhosh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/css/ext.translate.special.translate.css
b/resources/css/ext.translate.special.translate.css
index 68f5bc3..5c8bc2c 100644
--- a/resources/css/ext.translate.special.translate.css
+++ b/resources/css/ext.translate.special.translate.css
@@ -199,7 +199,7 @@
margin-top: 50px;
}
-.tux-messagetable-header .tux-message-filter-box {
+.tux-message-filter-box {
font-size: 14px;
height: 28px;
border: 1px solid #C9C9C9;
@@ -207,13 +207,13 @@
padding: 0 5px;
}
-.tux-messagetable-header .tux-message-filter-box-icon {
- background: url('../images/search.png') no-repeat scroll right center
transparent;
+.tux-message-filter-wrapper {
+ background: url('../images/search.png') no-repeat scroll left center
transparent;
background-image: -webkit-linear-gradient(transparent, transparent),
url(../images/search.svg);
/* @embed */
background-image: linear-gradient(transparent, transparent),
url(../images/search.svg);
background-size: 25px;
- height: 28px;
+ padding-left: 30px;
}
.client-nojs .tux-messagetable-header {
diff --git a/specials/SpecialTranslate.php b/specials/SpecialTranslate.php
index 8212670..ce17ce1 100644
--- a/specials/SpecialTranslate.php
+++ b/specials/SpecialTranslate.php
@@ -555,15 +555,12 @@
$output .= Html::closeElement( 'ul' );
$output .= Html::closeElement( 'div' ); // close nine columns
$output .= Html::openElement( 'div', array( 'class' => 'three
columns' ) );
- $output .= Html::openElement( 'div', array( 'class' => 'two
columns' ) );
- $output .= Html::element( 'div', array( 'class' =>
'tux-message-filter-box-icon' ) );
- $output .= Html::closeElement( 'div' ); // close two columns
- $output .= Html::openElement( 'div', array( 'class' => 'ten
columns' ) );
+ $output .= Html::openElement( 'div', array( 'class' =>
'tux-message-filter-wrapper' ) );
$output .= Html::element( 'input', array(
'class' => 'tux-message-filter-box',
'type' => 'search',
) );
- $output .= Html::closeElement( 'div' ); // close ten columns
+ $output .= Html::closeElement( 'div' ); // close
tux-message-filter-wrapper
$output .= Html::closeElement( 'div' ); // close three columns
--
To view, visit https://gerrit.wikimedia.org/r/292327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98158499594a0bdbb13a236b10667e41d22caac2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
