jenkins-bot has submitted this change and it was merged.
Change subject: On translation pages in source language, show "Translate this
page" in header
......................................................................
On translation pages in source language, show "Translate this page" in header
Bug: T58518
Depends-On: I36df72b13584de1aae489e2d9b4c4704e20d480a
Change-Id: Iacd05b8a3cf01f6ddcfe77f2e6598ac3f28eb528
---
M tag/PageTranslationHooks.php
1 file changed, 28 insertions(+), 17 deletions(-)
Approvals:
Nikerabbit: Checked; Looks good to me, approved
jenkins-bot: Verified
diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php
index 261576e..5a2b286 100644
--- a/tag/PageTranslationHooks.php
+++ b/tag/PageTranslationHooks.php
@@ -675,17 +675,7 @@
$actions = array();
if ( $marked && $context->getUser()->isAllowed( 'translate' ) )
{
- $actions[] = Linker::linkKnown(
- SpecialPage::getTitleFor( 'Translate' ),
- $context->msg(
'translate-tag-translate-link-desc' )->escaped(),
- array(),
- array(
- 'group' => $page->getMessageGroupId(),
- 'language' => $language->getCode(),
- 'action' => 'page',
- 'filter' => '',
- )
- );
+ $actions[] = self::getTranslateLink( $context, $page,
$language->getCode() );
}
$hasChanges = $ready === $latest && $marked !== $latest;
@@ -727,6 +717,22 @@
$context->getOutput()->addHTML( $header );
}
+ private static function getTranslateLink( IContextSource $context,
+ TranslatablePage $page, $langCode
+ ) {
+ return Linker::linkKnown(
+ SpecialPage::getTitleFor( 'Translate' ),
+ $context->msg(
'translate-tag-translate-link-desc' )->escaped(),
+ array(),
+ array(
+ 'group' => $page->getMessageGroupId(),
+ 'language' => $langCode,
+ 'action' => 'page',
+ 'filter' => '',
+ )
+ );
+ }
+
protected static function translationPageHeader( Title $title,
TranslatablePage $page ) {
if ( !$title->exists() ) {
return;
@@ -744,12 +750,17 @@
$context = RequestContext::getMain();
$language = $context->getLanguage();
- $url = wfExpandUrl( $page->getTranslationUrl( $code ),
PROTO_RELATIVE );
- $msg = $context->msg( 'tpt-translation-intro',
- $url,
- ':' . $page->getTitle()->getPrefixedText(),
- $language->formatNum( $per )
- )->parse();
+ if ( $page->getSourceLanguageCode() === $code ) {
+ // If we are on the source language page, link to
translate for user's language
+ $msg = self::getTranslateLink( $context, $page,
$language->getCode() );
+ } else {
+ $url = wfExpandUrl( $page->getTranslationUrl( $code ),
PROTO_RELATIVE );
+ $msg = $context->msg( 'tpt-translation-intro',
+ $url,
+ ':' . $page->getTitle()->getPrefixedText(),
+ $language->formatNum( $per )
+ )->parse();
+ }
$header = Html::rawElement(
'div',
--
To view, visit https://gerrit.wikimedia.org/r/293962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacd05b8a3cf01f6ddcfe77f2e6598ac3f28eb528
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
