Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/294082

Change subject: Fix name of the URL accessor
......................................................................

Fix name of the URL accessor

Also shuffle safe things

Change-Id: Ia7f46ecb8eacc50d8c7e81baf94a5c23c79e9fff
---
M paypal_gateway/express_checkout/paypal_express.adapter.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/82/294082/1

diff --git a/paypal_gateway/express_checkout/paypal_express.adapter.php 
b/paypal_gateway/express_checkout/paypal_express.adapter.php
index e7e7099..02ed1fc 100644
--- a/paypal_gateway/express_checkout/paypal_express.adapter.php
+++ b/paypal_gateway/express_checkout/paypal_express.adapter.php
@@ -31,10 +31,11 @@
         * authentication.
         */
        protected function isCertificateAuthentication() {
+               // TODO: generalize certificate path into a class.
                return isset( $this->account_config['CertificatePath'] );
        }
 
-       protected function getCommunicationUrl() {
+       protected function getProcessorUrl() {
                if ( !self::getGlobal( 'Test' ) ) {
                        if ( $this->isCertificateAuthentication() ) {
                                $url = self::getGlobal( 'CertificateURL' );
@@ -79,14 +80,15 @@
                        'ct_id' => true,
                );
        }
+
        function setGatewayDefaults() {}
 
        public function getCurlBaseOpts() {
                $opts = parent::getCurlBaseOpts();
 
                if ( $this->isCertificateAuthentication() ) {
-                       $opts[CURLOPT_SSLCERT] = 
$this->account_config['CertificatePath'];
                        $opts[CURLOPT_SSLCERTTYPE] = 'PEM';
+                       $opts[CURLOPT_SSLCERT] = 
$this->account_config['CertificatePath'];
                }
 
                return $opts;

-- 
To view, visit https://gerrit.wikimedia.org/r/294082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7f46ecb8eacc50d8c7e81baf94a5c23c79e9fff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to