jenkins-bot has submitted this change and it was merged.
Change subject: Call child serializeSuccess/Failure in ArticleTarget#serialize
......................................................................
Call child serializeSuccess/Failure in ArticleTarget#serialize
Instead of going straight to ArticleTarget's one.
This causes ve.init.mw.DesktopArticleTarget.prototype.serializeFail
to be called when using that target.
Bug: T134333
Change-Id: I6ec259830178439bc80ea162ba4ad035226022a7
---
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index 56b1fbf..92cbca3 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -1429,8 +1429,8 @@
oldid: this.revid,
etag: this.etag
}, 'serialize' )
- .done(
ve.init.mw.ArticleTarget.prototype.serializeSuccess.bind( this ) )
- .fail( ve.init.mw.ArticleTarget.prototype.serializeFail.bind(
this ) );
+ .done( this.serializeSuccess.bind( this ) )
+ .fail( this.serializeFail.bind( this ) );
return true;
};
--
To view, visit https://gerrit.wikimedia.org/r/294184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ec259830178439bc80ea162ba4ad035226022a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
