Hashar has uploaded a new change for review. https://gerrit.wikimedia.org/r/294270
Change subject: Get rid of .pep8 files ...................................................................... Get rid of .pep8 files Jenkins invokes the slave script /tools/puppet_pep8.py which does a tree traversal and runs pep8 whenever it find some python files. Nowadays the whole repository is compliant with flake8 and the few corner cases are ignored. We can safely drop all the .pep8 exceptions and finally stop using the /tools/puppet_pep8.py script. Bug: T114887 Change-Id: I6ada9909ada9c3b46c1629086a3dbd212a19814f --- D files/misc/.pep8 D modules/dataset/files/.pep8 D modules/diamond/files/.pep8 D modules/dnsrecursor/files/.pep8 D modules/dynamicproxy/files/.pep8 D modules/eventlogging/files/.pep8 D modules/ganglia/files/plugins/.pep8 D modules/icinga/files/.pep8 D modules/ldap/files/scripts/.pep8 D modules/letsencrypt/files/.pep8 D modules/librenms/files/.pep8 D modules/memcached/files/ganglia/.pep8 D modules/mysql_wmf/files/ganglia/plugins/.pep8 D modules/openstack/files/juno/nova/.pep8 D modules/openstack/files/juno/virtscripts/.pep8 D modules/openstack/files/kilo/virtscripts/.pep8 D modules/openstack/files/liberty/horizon/.pep8 D modules/openstack/files/liberty/virtscripts/.pep8 D modules/osm/files/ganglia/.pep8 D modules/postgresql/files/ganglia/.pep8 D modules/puppetmaster/files/.pep8 D modules/redis/files/ganglia/.pep8 D modules/servermon/files/.pep8 D modules/swift/files/.pep8 D modules/swift/files/SwiftMedia/wmf/.pep8 D modules/toollabs/files/.pep8 D modules/udp2log/files/.pep8 D modules/varnish/files/ganglia/.pep8 D utils/.pep8 29 files changed, 0 insertions(+), 122 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/70/294270/1 diff --git a/files/misc/.pep8 b/files/misc/.pep8 deleted file mode 100644 index ad4323f..0000000 --- a/files/misc/.pep8 +++ /dev/null @@ -1,5 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -ignore = E501 diff --git a/modules/dataset/files/.pep8 b/modules/dataset/files/.pep8 deleted file mode 100644 index ad4323f..0000000 --- a/modules/dataset/files/.pep8 +++ /dev/null @@ -1,5 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -ignore = E501 diff --git a/modules/diamond/files/.pep8 b/modules/diamond/files/.pep8 deleted file mode 100644 index da16ad3..0000000 --- a/modules/diamond/files/.pep8 +++ /dev/null @@ -1,3 +0,0 @@ -[pep8] -# 80 cols is too short -max-line-length=120 diff --git a/modules/dnsrecursor/files/.pep8 b/modules/dnsrecursor/files/.pep8 deleted file mode 100644 index bcc4cdd..0000000 --- a/modules/dnsrecursor/files/.pep8 +++ /dev/null @@ -1,6 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -# E241: multiple spaces after ',' -ignore = E501,E241 diff --git a/modules/dynamicproxy/files/.pep8 b/modules/dynamicproxy/files/.pep8 deleted file mode 100644 index f225d9e..0000000 --- a/modules/dynamicproxy/files/.pep8 +++ /dev/null @@ -1,3 +0,0 @@ -[pep8] -# 80 cols is too short -max-line-length=100 diff --git a/modules/eventlogging/files/.pep8 b/modules/eventlogging/files/.pep8 deleted file mode 100644 index 609e631..0000000 --- a/modules/eventlogging/files/.pep8 +++ /dev/null @@ -1,6 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -# E241: multiple spaces after ',' -ignore = E501,E241 diff --git a/modules/ganglia/files/plugins/.pep8 b/modules/ganglia/files/plugins/.pep8 deleted file mode 100644 index 93c1664..0000000 --- a/modules/ganglia/files/plugins/.pep8 +++ /dev/null @@ -1,4 +0,0 @@ -[pep8] - -# These files are all from upstream. So, just ignore them. -exclude=* diff --git a/modules/icinga/files/.pep8 b/modules/icinga/files/.pep8 deleted file mode 100644 index ad4323f..0000000 --- a/modules/icinga/files/.pep8 +++ /dev/null @@ -1,5 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -ignore = E501 diff --git a/modules/ldap/files/scripts/.pep8 b/modules/ldap/files/scripts/.pep8 deleted file mode 100644 index baa77a4..0000000 --- a/modules/ldap/files/scripts/.pep8 +++ /dev/null @@ -1,5 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -ignore = E501 diff --git a/modules/letsencrypt/files/.pep8 b/modules/letsencrypt/files/.pep8 deleted file mode 100644 index 79e6916..0000000 --- a/modules/letsencrypt/files/.pep8 +++ /dev/null @@ -1,3 +0,0 @@ -[pep8] - -exclude=acme_tiny.py diff --git a/modules/librenms/files/.pep8 b/modules/librenms/files/.pep8 deleted file mode 100644 index bd39b63..0000000 --- a/modules/librenms/files/.pep8 +++ /dev/null @@ -1,3 +0,0 @@ -[pep8] -# This is a third-party file, so I'm just turning off everything... -ignore = W191,E225,E501,W239,E303,W209,E302,W293,E101,E128,E121,E703,W291,E401,E701,E221,E211,E203 diff --git a/modules/memcached/files/ganglia/.pep8 b/modules/memcached/files/ganglia/.pep8 deleted file mode 100644 index 93c1664..0000000 --- a/modules/memcached/files/ganglia/.pep8 +++ /dev/null @@ -1,4 +0,0 @@ -[pep8] - -# These files are all from upstream. So, just ignore them. -exclude=* diff --git a/modules/mysql_wmf/files/ganglia/plugins/.pep8 b/modules/mysql_wmf/files/ganglia/plugins/.pep8 deleted file mode 100644 index 93c1664..0000000 --- a/modules/mysql_wmf/files/ganglia/plugins/.pep8 +++ /dev/null @@ -1,4 +0,0 @@ -[pep8] - -# These files are all from upstream. So, just ignore them. -exclude=* diff --git a/modules/openstack/files/juno/nova/.pep8 b/modules/openstack/files/juno/nova/.pep8 deleted file mode 100644 index ad4323f..0000000 --- a/modules/openstack/files/juno/nova/.pep8 +++ /dev/null @@ -1,5 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -ignore = E501 diff --git a/modules/openstack/files/juno/virtscripts/.pep8 b/modules/openstack/files/juno/virtscripts/.pep8 deleted file mode 100644 index 542c110..0000000 --- a/modules/openstack/files/juno/virtscripts/.pep8 +++ /dev/null @@ -1,3 +0,0 @@ -[pep8] -# This is a third-party file, so I'm just turning off everything... -ignore = W191,E225,E501,W239,E303,W209,E302,W293,E101,E128,E121,E703,W291 diff --git a/modules/openstack/files/kilo/virtscripts/.pep8 b/modules/openstack/files/kilo/virtscripts/.pep8 deleted file mode 100644 index 77f5a1c..0000000 --- a/modules/openstack/files/kilo/virtscripts/.pep8 +++ /dev/null @@ -1,3 +0,0 @@ -[pep8] -# This is a third-party file, so I'm just turning off everything... -ignore = W191,E225,E501,W239,E303,W209,E302,W293,E101,E128,E121,E703,W291,E131,E265 diff --git a/modules/openstack/files/liberty/horizon/.pep8 b/modules/openstack/files/liberty/horizon/.pep8 deleted file mode 100644 index 1829933..0000000 --- a/modules/openstack/files/liberty/horizon/.pep8 +++ /dev/null @@ -1,3 +0,0 @@ -[pep8] -# This is a third-party file, so I'm just turning off everything... -ignore = E501 diff --git a/modules/openstack/files/liberty/virtscripts/.pep8 b/modules/openstack/files/liberty/virtscripts/.pep8 deleted file mode 100644 index 77f5a1c..0000000 --- a/modules/openstack/files/liberty/virtscripts/.pep8 +++ /dev/null @@ -1,3 +0,0 @@ -[pep8] -# This is a third-party file, so I'm just turning off everything... -ignore = W191,E225,E501,W239,E303,W209,E302,W293,E101,E128,E121,E703,W291,E131,E265 diff --git a/modules/osm/files/ganglia/.pep8 b/modules/osm/files/ganglia/.pep8 deleted file mode 100644 index 93c1664..0000000 --- a/modules/osm/files/ganglia/.pep8 +++ /dev/null @@ -1,4 +0,0 @@ -[pep8] - -# These files are all from upstream. So, just ignore them. -exclude=* diff --git a/modules/postgresql/files/ganglia/.pep8 b/modules/postgresql/files/ganglia/.pep8 deleted file mode 100644 index 93c1664..0000000 --- a/modules/postgresql/files/ganglia/.pep8 +++ /dev/null @@ -1,4 +0,0 @@ -[pep8] - -# These files are all from upstream. So, just ignore them. -exclude=* diff --git a/modules/puppetmaster/files/.pep8 b/modules/puppetmaster/files/.pep8 deleted file mode 100644 index baa77a4..0000000 --- a/modules/puppetmaster/files/.pep8 +++ /dev/null @@ -1,5 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -ignore = E501 diff --git a/modules/redis/files/ganglia/.pep8 b/modules/redis/files/ganglia/.pep8 deleted file mode 100644 index 93c1664..0000000 --- a/modules/redis/files/ganglia/.pep8 +++ /dev/null @@ -1,4 +0,0 @@ -[pep8] - -# These files are all from upstream. So, just ignore them. -exclude=* diff --git a/modules/servermon/files/.pep8 b/modules/servermon/files/.pep8 deleted file mode 100644 index de50795..0000000 --- a/modules/servermon/files/.pep8 +++ /dev/null @@ -1,2 +0,0 @@ -[pep8] -ignore = E128,E127,E241 diff --git a/modules/swift/files/.pep8 b/modules/swift/files/.pep8 deleted file mode 100644 index 16c865a..0000000 --- a/modules/swift/files/.pep8 +++ /dev/null @@ -1,6 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -# E221: multiple spaces before operator -ignore = E501,E241 diff --git a/modules/swift/files/SwiftMedia/wmf/.pep8 b/modules/swift/files/SwiftMedia/wmf/.pep8 deleted file mode 100644 index c3efd5d..0000000 --- a/modules/swift/files/SwiftMedia/wmf/.pep8 +++ /dev/null @@ -1,6 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -# E221: multiple spaces before operator -ignore = E501,E221 diff --git a/modules/toollabs/files/.pep8 b/modules/toollabs/files/.pep8 deleted file mode 100644 index 609e631..0000000 --- a/modules/toollabs/files/.pep8 +++ /dev/null @@ -1,6 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -# E241: multiple spaces after ',' -ignore = E501,E241 diff --git a/modules/udp2log/files/.pep8 b/modules/udp2log/files/.pep8 deleted file mode 100644 index ad4323f..0000000 --- a/modules/udp2log/files/.pep8 +++ /dev/null @@ -1,5 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -ignore = E501 diff --git a/modules/varnish/files/ganglia/.pep8 b/modules/varnish/files/ganglia/.pep8 deleted file mode 100644 index 2f6357a..0000000 --- a/modules/varnish/files/ganglia/.pep8 +++ /dev/null @@ -1,2 +0,0 @@ -[pep8] -exclude=* diff --git a/utils/.pep8 b/utils/.pep8 deleted file mode 100644 index ad4323f..0000000 --- a/utils/.pep8 +++ /dev/null @@ -1,5 +0,0 @@ -[pep8] - -# Suppress warnings: -# E501: line too long -ignore = E501 -- To view, visit https://gerrit.wikimedia.org/r/294270 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6ada9909ada9c3b46c1629086a3dbd212a19814f Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
