Adrian Heine has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294277
Change subject: Pass boolean to toggleClass as required
......................................................................
Pass boolean to toggleClass as required
If you pass null or undefined, it will literally toggle.
Change-Id: I485c575f96af76f2c4ec19c8654404632a7558d3
---
M view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/77/294277/1
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
index 076fb60..2e7d8f9 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementgroupview.js
@@ -122,7 +122,7 @@
$statementlistview
.on( prefix + 'toggleerror.' + this.widgetName, function(
event, error ) {
- self.$property.toggleClass( 'wb-error', error );
+ self.$property.toggleClass( 'wb-error', Boolean( error
) );
} )
.on( prefix + 'afterstopediting.' + this.widgetName, function(
event, dropValue ) {
self.$property.removeClass( 'wb-error' ).removeClass(
'wb-edit' );
--
To view, visit https://gerrit.wikimedia.org/r/294277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I485c575f96af76f2c4ec19c8654404632a7558d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Heine <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
