jenkins-bot has submitted this change and it was merged.
Change subject: tools/puppet_pep8.py is no more needed
......................................................................
tools/puppet_pep8.py is no more needed
operations/puppet.git is no 100% compliant with latest flake8 and the CI
jobs have been switched to use 'tox' which runs flake8.
The old tools/puppet_pep8.py wrapper is thus no more needed.
Bug: T114887
Change-Id: I03e968881e2af18e8d1819ef0305bf94a4815425
---
D tools/puppet_pep8.py
1 file changed, 0 insertions(+), 51 deletions(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tools/puppet_pep8.py b/tools/puppet_pep8.py
deleted file mode 100755
index 719ed04..0000000
--- a/tools/puppet_pep8.py
+++ /dev/null
@@ -1,51 +0,0 @@
-#!/usr/bin/python
-# coding=utf-8
-#
-# Released under GPLv2
-#
-# Copyright © 2013 Andrew Bogott
-# Copyright © 2013 Antoine Musso
-# Copyright © 2013 Wikimedia Foundation Inc.
-#
-"""
-Run the pep8 tool on each file in <path> and its subdirs.
-
-This differs from the normal pep8 tool in that pep8 is invoked per file rather
-than as one job; this means pep8 might load a different .pep8 rule for each
-subdir.
-"""
-
-import argparse
-import os
-import subprocess
-
-parser = argparse.ArgumentParser(description=__doc__)
-parser.add_argument('path', help='top level dir to begin pep8 tests')
-args = parser.parse_args()
-
-dir_tuples = os.walk(args.path)
-
-success = True
-for dir_tuple in dir_tuples:
- (dirpath, dirnames, filenames) = dir_tuple
- for f in filenames:
- if os.path.splitext(f)[1] != ".py":
- continue
- file_path = os.path.join(dirpath, f)
-
- # Craft a relative path to get shorter lines output
- rel_path = os.path.relpath(file_path, args.path)
-
- print("Checking file %s" % file_path)
- cmd = ('pep8', rel_path)
-
- # Invoke pep8 from the directory passed as an argument
- if subprocess.call(cmd, cwd=args.path):
- success = False
-
-if success:
- print("\n\nAll tests passed.")
- exit(0)
-else:
- print("\n\nSome tests failed. Review pep8 output above.")
- exit(1)
--
To view, visit https://gerrit.wikimedia.org/r/294278
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03e968881e2af18e8d1819ef0305bf94a4815425
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
