Adrian Heine has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/294281

Change subject: Remove noop teardown in statementview test
......................................................................

Remove noop teardown in statementview test

Change-Id: I5391be817436b515e6b047ae79ceab23343d46ea
---
M view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
1 file changed, 1 insertion(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/81/294281/1

diff --git 
a/view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js 
b/view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
index 3b83220..e8f10a7 100644
--- a/view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
+++ b/view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
@@ -5,20 +5,7 @@
 ( function( $, mw, wb, dv, QUnit, sinon ) {
 'use strict';
 
-QUnit.module( 'jquery.wikibase.statementview', QUnit.newMwEnvironment( {
-       teardown: function() {
-               $( '.test_statementview' ).each( function() {
-                       var $statementview = $( this ),
-                               statementview = $statementview.data( 
'statementview' );
-
-                       if ( statementview ) {
-                               statementview.destroy();
-                       }
-
-                       $statementview.remove();
-               } );
-       }
-} ) );
+QUnit.module( 'jquery.wikibase.statementview', QUnit.newMwEnvironment() );
 
 /**
  * @param {Object} [options]

-- 
To view, visit https://gerrit.wikimedia.org/r/294281
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5391be817436b515e6b047ae79ceab23343d46ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Heine <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to