jenkins-bot has submitted this change and it was merged. Change subject: BREAKING CHANGE: Update jQuery Client to v2.0.0 ......................................................................
BREAKING CHANGE: Update jQuery Client to v2.0.0 Breaking change * Microsoft's new Edge browser is now identified as "edge" instead of "msie". Project link * https://github.com/wikimedia/jquery-client File link * https://github.com/wikimedia/jquery-client/blob/v2.0.0/jquery.client.js Change-Id: I2575e38cf8367ddab429201a056895b1e8c7171b --- M lib/jquery.client/jquery.client.js 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Esanders: Looks good to me, approved jenkins-bot: Verified Objections: Jforrester: There's a problem with this change, please improve diff --git a/lib/jquery.client/jquery.client.js b/lib/jquery.client/jquery.client.js index 1560c7d..8257d85 100644 --- a/lib/jquery.client/jquery.client.js +++ b/lib/jquery.client/jquery.client.js @@ -1,5 +1,5 @@ /*! - * jQuery Client v1.0.0 + * jQuery Client v2.0.0 * https://www.mediawiki.org/wiki/JQuery_Client * * Copyright 2010-2015 jquery-client maintainers and other contributors. @@ -182,9 +182,12 @@ version = match[1]; } } - // And IE 12's different lies about not being IE + // And MS Edge's lies about being Chrome + // + // It's different enough from classic IE Trident engine that they do this + // to avoid getting caught by MSIE-specific browser sniffing. if ( name === 'chrome' && ( match = ua.match( /\bedge\/([0-9\.]*)/ ) ) ) { - name = 'msie'; + name = 'edge'; version = match[1]; layout = 'edge'; layoutversion = parseInt( match[1], 10 ); -- To view, visit https://gerrit.wikimedia.org/r/221171 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2575e38cf8367ddab429201a056895b1e8c7171b Gerrit-PatchSet: 6 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
