[MediaWiki-commits] [Gerrit] Allow FeedClients to return Card subclasses - change (apps...wikipedia)

[Niedzielski (Code Review)]

Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/294378

Change subject: Allow FeedClients to return Card subclasses
......................................................................

Allow FeedClients to return Card subclasses

Change-Id: I039ba6291f90506f05eb74750084aedbcdcf9bda
---
M app/src/main/java/org/wikipedia/feed/FeedClient.java
M app/src/main/java/org/wikipedia/feed/FeedCoordinatorBase.java
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/78/294378/1

diff --git a/app/src/main/java/org/wikipedia/feed/FeedClient.java 
b/app/src/main/java/org/wikipedia/feed/FeedClient.java
index 0834840..c7b9913 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedClient.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedClient.java
@@ -13,7 +13,7 @@
     void cancel();
 
     interface Callback {
-        void success(@NonNull List<Card> cards);
+        void success(@NonNull List<? extends Card> cards);
         void error(@NonNull Throwable caught);
     }
 }
diff --git a/app/src/main/java/org/wikipedia/feed/FeedCoordinatorBase.java 
b/app/src/main/java/org/wikipedia/feed/FeedCoordinatorBase.java
index bedb9e3..16781b4 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedCoordinatorBase.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedCoordinatorBase.java
@@ -72,7 +72,7 @@
 
     private class ExhaustionClientCallback implements FeedClient.Callback {
         @Override
-        public void success(@NonNull List<Card> cardList) {
+        public void success(@NonNull List<? extends Card> cardList) {
             cards.addAll(cardList);
             if (updateListener != null) {
                 updateListener.update(cards);

-- 
To view, visit https://gerrit.wikimedia.org/r/294378
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I039ba6291f90506f05eb74750084aedbcdcf9bda
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits