PleaseStand has uploaded a new change for review. https://gerrit.wikimedia.org/r/294413
Change subject: Maintenance: Use __DIR__ instead of dirname( __FILE__ ) ...................................................................... Maintenance: Use __DIR__ instead of dirname( __FILE__ ) dirname( __FILE__ ) was used because it worked in PHP 5.2, allowing the version check to function correctly. However, Maintenance.php now uses the short array syntax, which is a parse error before 5.4: > Parse error: syntax error, unexpected '[' in maintenance/Maintenance.php > on line 66 Change-Id: I3373a02c684bb6cbde83d7bedc204818f3394602 --- M maintenance/Maintenance.php 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/13/294413/1 diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php index a08297a..27d8161 100644 --- a/maintenance/Maintenance.php +++ b/maintenance/Maintenance.php @@ -21,10 +21,8 @@ */ // Bail on old versions of PHP, or if composer has not been run yet to install -// dependencies. Using dirname( __FILE__ ) here because __DIR__ is PHP5.3+. -// @codingStandardsIgnoreStart MediaWiki.Usage.DirUsage.FunctionFound -require_once dirname( __FILE__ ) . '/../includes/PHPVersionCheck.php'; -// @codingStandardsIgnoreEnd +// dependencies. +require_once __DIR__ . '/../includes/PHPVersionCheck.php'; wfEntryPointCheck( 'cli' ); /** -- To view, visit https://gerrit.wikimedia.org/r/294413 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3373a02c684bb6cbde83d7bedc204818f3394602 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: PleaseStand <pleasest...@live.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
