Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294479
Change subject: Add fail handlers for link card data fetching
......................................................................
Add fail handlers for link card data fetching
In case of magic links which are different from wiki links,
the data fetch will fail and result in card occupying the tool
column but in incomplete state. The fail handler is hiding it now
Bug: T137875
Change-Id: I308e5cad41cf8363769de368c3cc3daea1ddbf7e
---
M modules/tools/ext.cx.tools.link.js
1 file changed, 4 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/79/294479/1
diff --git a/modules/tools/ext.cx.tools.link.js
b/modules/tools/ext.cx.tools.link.js
index 5e68d35..0d2bde9 100644
--- a/modules/tools/ext.cx.tools.link.js
+++ b/modules/tools/ext.cx.tools.link.js
@@ -930,12 +930,16 @@
if ( page ) {
self.$card.prepend( self.sourceLink.getCard() );
}
+ } ).fail( function () {
+ self.stop();
} );
this.targetLink.fetchLinkData().done( function () {
self.$card.append( self.targetLink.getCard() );
self.$card.show();
self.onShow();
+ } ).fail( function () {
+ self.stop();
} );
};
--
To view, visit https://gerrit.wikimedia.org/r/294479
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I308e5cad41cf8363769de368c3cc3daea1ddbf7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
