MarkTraceur has submitted this change and it was merged.
Change subject: (bug 40646) Errant line break in "Use a different license
option"
......................................................................
(bug 40646) Errant line break in "Use a different license option"
Steps to see where the line break was:
1. Upload multiple files on uploadwizard
2. Select "Provide copyright information for each file individually on the next
page"
3. Select "this is my own file work" and then "use a different license option"
In the <label> used to display various options with radio buttons, text-indent
is set as 0px to match the indentation, gave padding-top:2px to separate
between the two labels
But then the radio buttons were not displayed at proper places so used
vertical-align:top in input['type'=radio].mwe-upwiz-copyright-info, the class
is added in mw.UploadWizardLicenseInput.js as
$input.addClass('mwe-upwiz-copyright-info-radio').
Since the break was occuring at "legal" which did not suit, so used <br> before
the parenthesis in i18n
Change-Id: I883f6f44082fe40b89604fa16016b5443979bc79
---
M UploadWizard.i18n.php
M resources/mw.UploadWizardLicenseInput.js
M resources/uploadWizard.css
3 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
MarkTraceur: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/44686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I883f6f44082fe40b89604fa16016b5443979bc79
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Rjain <[email protected]>
Gerrit-Reviewer: Aklapper <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: Rjain <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
