Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294688
Change subject: SpecialManageTranslatorSandbox: avoid FOUC
......................................................................
SpecialManageTranslatorSandbox: avoid FOUC
Separated styles to a different module. Due to changes in loading order I had
to increase specificity of some CSS classes. This is good because it means
that sometimes users could see broken interface if loading order was different.
Change-Id: Icdbfe14d726c8bad8f9e34ef6b94ac6c2498cb6e
---
M Resources.php
M resources/css/ext.translate.special.managetranslatorsandbox.css
M specials/SpecialManageTranslatorSandbox.php
3 files changed, 14 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/88/294688/1
diff --git a/Resources.php b/Resources.php
index acecf39..63a7b9e 100644
--- a/Resources.php
+++ b/Resources.php
@@ -312,8 +312,6 @@
$wgResourceModules['ext.translate.special.managetranslatorsandbox'] = array(
'scripts' =>
'resources/js/ext.translate.special.managetranslatorsandbox.js',
- 'styles' =>
'resources/css/ext.translate.special.managetranslatorsandbox.css',
- 'position' => 'top',
'dependencies' => array(
'ext.translate.loader',
'ext.translate.translationstashstorage',
@@ -346,6 +344,10 @@
),
) + $resourcePaths;
+$wgResourceModules['ext.translate.special.managetranslatorsandbox.styles'] =
array(
+ 'styles' =>
'resources/css/ext.translate.special.managetranslatorsandbox.css',
+) + $resourcePaths;
+
$wgResourceModules['ext.translate.special.pagemigration'] = array(
'styles' => 'resources/css/ext.translate.special.pagemigration.css',
'scripts' => 'resources/js/ext.translate.special.pagemigration.js',
diff --git a/resources/css/ext.translate.special.managetranslatorsandbox.css
b/resources/css/ext.translate.special.managetranslatorsandbox.css
index 08ffa04..5bd1181 100644
--- a/resources/css/ext.translate.special.managetranslatorsandbox.css
+++ b/resources/css/ext.translate.special.managetranslatorsandbox.css
@@ -20,7 +20,7 @@
font-size: 24px;
}
-.search.pane {
+.grid .search.pane {
background: url('../images/search.png') no-repeat scroll left top
transparent;
background-image: -webkit-linear-gradient(transparent, transparent),
url(../images/search.svg);
/* @embed */
@@ -52,16 +52,16 @@
overflow: auto;
}
-.details.pane {
+.grid .details.pane {
border-left: 1px solid #DDDDDD;
left: -1px;
padding: 5px 20px 10px 20px;
}
/* Requests pane */
-.requests.pane,
-.requests.pane .request,
-.requests.pane .request-header {
+.grid .requests.pane,
+.grid .requests.pane .request,
+.grid .requests.pane .request-header {
margin: 0;
padding: 0;
}
@@ -84,7 +84,7 @@
background-color: #f0f0f0;
}
-.request .amount {
+.grid .request .amount {
height: 100%;
font-size: 3em;
color: #96989A;
@@ -122,8 +122,8 @@
overflow: hidden;
}
-.request .request-info,
-.request .approval {
+.grid .request .request-info,
+.grid .request .approval {
padding-top: 5px;
}
diff --git a/specials/SpecialManageTranslatorSandbox.php
b/specials/SpecialManageTranslatorSandbox.php
index 3a82d50..123c770 100644
--- a/specials/SpecialManageTranslatorSandbox.php
+++ b/specials/SpecialManageTranslatorSandbox.php
@@ -38,7 +38,8 @@
$this->setHeaders();
$this->checkPermissions();
$out = $this->getOutput();
- $out->addModuleStyles( 'mediawiki.ui.button' );
+ $out->addModuleStyles( array( 'mediawiki.ui.button',
'jquery.uls.grid' ) );
+ $out->addModuleStyles(
'ext.translate.special.managetranslatorsandbox.styles' );
$out->addModules(
'ext.translate.special.managetranslatorsandbox' );
$this->stash = new TranslationStashStorage( wfGetDB( DB_MASTER
) );
--
To view, visit https://gerrit.wikimedia.org/r/294688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icdbfe14d726c8bad8f9e34ef6b94ac6c2498cb6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
