jenkins-bot has submitted this change and it was merged.
Change subject: Fix mapframe not displaying properly when placed inside a
collapsible container.
......................................................................
Fix mapframe not displaying properly when placed
inside a collapsible container.
Bug: T137815
Change-Id: I351d84e4b7dcbdbba87bdc1f8b9c163ce00c12f6
(cherry picked from commit f94c31cfc2114c02fd88d5f195fec6d3d95b2e1d)
---
M modules/kartographer.js
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/kartographer.js b/modules/kartographer.js
index ec934df..206ca96 100644
--- a/modules/kartographer.js
+++ b/modules/kartographer.js
@@ -576,6 +576,17 @@
mw.kartographer.openFullscreenMap( map, getMapPosition( map ) );
}
} );
+
+ // Special case for collapsible maps.
+ // When the container is hidden Leaflet is not
able to
+ // calculate the expected size when visible. We
need to force
+ // updating the map to the new container size
on `expand`.
+ if ( !$container.is( ':visible' ) ) {
+ $container.closest( '.mw-collapsible' )
+ .on(
'afterExpand.mw-collapsible', function () {
+ map.invalidateSize();
+ } );
+ }
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/294856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I351d84e4b7dcbdbba87bdc1f8b9c163ce00c12f6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: wmf/1.28.0-wmf.6
Gerrit-Owner: Yurik <yu...@wikimedia.org>
Gerrit-Reviewer: JGirault <julien.inbox.w...@gmail.com>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
