Arlolra has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295026
Change subject: T96195: Deprecate node 0.8 support
......................................................................
T96195: Deprecate node 0.8 support
Change-Id: I8a2282df96ec06fc3e4d706d731a63d7d6dbf365
---
M .travis.yml
M HISTORY.md
M bin/server.js
M lib/api/apiUtils.js
M package.json
5 files changed, 4 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/26/295026/1
diff --git a/.travis.yml b/.travis.yml
index 75e4993..f4e00f1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,18 +1,12 @@
language: node_js
node_js:
- # Your days are numbered.
- - "0.8"
# Current production value.
- "0.10.25"
# Aspiring contender. See T119228.
- "4.3.0"
# From the nvm docs, "this installs the latest version of node".
- "node"
-
-before_install:
- - NODE_VERSION=$(node -e
'console.log(process.version.replace(/[.][0-9]+$/, ""))')
- - if [ "v0.8" = "$NODE_VERSION" ]; then npm install -g [email protected] ; fi
script: travis_wait npm run-script coverage && (npm run-script coveralls ||
exit 0)
diff --git a/HISTORY.md b/HISTORY.md
index 76bd87c..83f0787 100644
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -9,6 +9,7 @@
* T125419: Fix selser issues serializing first table row
* T114413: Provide HTML2HTML endpoint in Parsoid
* T137406: Emit |- between thead/tbody/tfoot
+ * T96195: Deprecate node 0.8 support
0.5.1 / 2015-05-02
==================
diff --git a/bin/server.js b/bin/server.js
index 2a38f83..eae5e22 100755
--- a/bin/server.js
+++ b/bin/server.js
@@ -228,8 +228,7 @@
// Enable heap dumps in /tmp on kill -USR2.
// See https://github.com/bnoordhuis/node-heapdump/
- // For node 0.6/0.8: npm install [email protected]
- // For 0.10: npm install heapdump
+ // npm install heapdump
process.on('SIGUSR2', function() {
var heapdump = require('heapdump');
processLogger.log("warning", "SIGUSR2 received! Writing
snapshot.");
diff --git a/lib/api/apiUtils.js b/lib/api/apiUtils.js
index d64b383..57f8454 100644
--- a/lib/api/apiUtils.js
+++ b/lib/api/apiUtils.js
@@ -4,7 +4,6 @@
var cluster = require('cluster');
var domino = require('domino');
var util = require('util');
-var semver = require('semver');
var qs = require('querystring');
var Diff = require('../utils/Diff.js').Diff;
@@ -154,9 +153,6 @@
};
};
-// Cluster support was very experimental and missing methods in v0.8.x
-var sufficientNodeVersion = semver.gte(process.version, '0.10.0');
-
/**
* @method
* @param {Promise} p
@@ -170,7 +166,7 @@
(res.locals.oldid ? '?oldid=' + res.locals.oldid : '')
);
return new Promise(function(resolve, reject) {
- if (cluster.isMaster || !sufficientNodeVersion) {
+ if (cluster.isMaster) {
return p.then(resolve, reject);
}
// Notify the cluster master that a request has started
diff --git a/package.json b/package.json
index 1aea493..6152301 100644
--- a/package.json
+++ b/package.json
@@ -49,7 +49,6 @@
},
"scripts": {
"lint": "npm run dump-tokenizer && npm run jscs && npm run jshint",
- "no-0.8": "node -e 'process.exit(/v0[.][0-8][.]/.test(process.version) ? 0
: 1)' || (npm run nsp && npm run lint)",
"start": "node bin/server.js",
"jshint": "jshint bin lib tests tools core-upgrade.js",
"jscs": "jscs bin lib tests tools core-upgrade.js",
@@ -58,7 +57,7 @@
"mocha": "mocha --opts tests/mocha/mocha.opts tests/mocha",
"parserTests": "node bin/parserTests.js --wt2html --wt2wt --html2wt
--html2html --selser --no-color --quiet --blacklist",
"roundtrip": "node bin/roundtrip-test.js 'Barack Obama' && node
bin/roundtrip-test.js 'Parkour'",
- "test": "npm run no-0.8 && npm run parserTests && npm run mocha",
+ "test": "npm run nsp && npm run lint && npm run parserTests && npm run
mocha",
"cover-mocha": "istanbul cover _mocha --dir ./coverage/mocha -- --opts
tests/mocha/mocha.opts tests/mocha",
"cover-parserTests": "istanbul cover bin/parserTests.js --dir
./coverage/parserTests -- --wt2html --wt2wt --html2wt --html2html --selser
--no-color --quiet --blacklist",
"coverage": "npm run cover-mocha && npm run cover-parserTests && istanbul
report",
--
To view, visit https://gerrit.wikimedia.org/r/295026
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a2282df96ec06fc3e4d706d731a63d7d6dbf365
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
