jenkins-bot has submitted this change and it was merged.
Change subject: Wrap table-cell buttons in table-row
......................................................................
Wrap table-cell buttons in table-row
Removes unwanted 2px bottom margin from footer buttons.
Change-Id: I67c1d5f21d7c62a436010932e3d7b6257e4b73ff
---
M modules/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 25 insertions(+), 21 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
index 9de6b64..1865673 100644
--- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -61,30 +61,34 @@
display: block;
}
-
.mw-echo-ui-notificationBadgeButtonPopupWidget-footer-buttons
.oo-ui-buttonElement {
- display: table-cell;
- white-space: normal;
- font-weight: bold;
- width: @notification-popup-width / 2;
- box-sizing: border-box;
+
.mw-echo-ui-notificationBadgeButtonPopupWidget-footer-buttons {
+ display: table-row;
- &:last-child {
- border-left: 1px solid #DDDDDD;
- }
+ .oo-ui-buttonElement {
+ display: table-cell;
+ white-space: normal;
+ font-weight: bold;
+ width:
@notification-popup-width / 2;
+ box-sizing: border-box;
- > .oo-ui-buttonElement-button {
- display: block;
- line-height: 2.6em;
- margin: 0;
- border: 0;
- padding: 0.5em;
+ &:last-child {
+ border-left: 1px solid
#DDDDDD;
+ }
- .oo-ui-iconElement-icon {
- // HACK: these are
absolutely positioned in OOUI, and our line-height: 4em;
- // rule breaks that.
- // FIXME: We should
really use a different widget here
- position: static;
- opacity: @opacity-mid;
+ > .oo-ui-buttonElement-button {
+ display: block;
+ line-height: 2.6em;
+ margin: 0;
+ border: 0;
+ padding: 0.5em;
+
+ .oo-ui-iconElement-icon
{
+ // HACK: these
are absolutely positioned in OOUI, and our line-height: 4em;
+ // rule breaks
that.
+ // FIXME: We
should really use a different widget here
+ position:
static;
+ opacity:
@opacity-mid;
+ }
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/295381
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67c1d5f21d7c62a436010932e3d7b6257e4b73ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
