BBlack has submitted this change and it was merged.
Change subject: cache_upload: experiment with higher fe hfp cutoff
......................................................................
cache_upload: experiment with higher fe hfp cutoff
This changes the size cutoff for frontend hit-for-pass from 32MB
to 48MB. The reason we have this limit at all is to prevent very
large objects from evicting too many small ones in the limited
frontend memory space.
We've increased the size of the FE caches significantly in the
recent past, so 48MB should be acceptable in basic terms. We've
recently experimented with raising the FE TTL cap from 1h to 4h
and that had virtually no effect on FE hitrate, so the remaining
likely explanations for the current limit are the HFP size cutoff
(which this patch tests) or total cache size (vs hot set size).
Change-Id: I0dbfb288a73aaa35f5532a6499d50b1f60ed622b
---
M templates/varnish/upload-frontend.inc.vcl.erb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
BBlack: Verified; Looks good to me, approved
diff --git a/templates/varnish/upload-frontend.inc.vcl.erb
b/templates/varnish/upload-frontend.inc.vcl.erb
index 9f31006..ea173dd 100644
--- a/templates/varnish/upload-frontend.inc.vcl.erb
+++ b/templates/varnish/upload-frontend.inc.vcl.erb
@@ -71,7 +71,7 @@
<% stream_threshold = @cache_route == 'direct' ? 33554432 : 1048576 -%>
if (std.integer(beresp.http.Content-Length, 33554432) >= <%=
stream_threshold %> || beresp.http.Content-Length ~ "^[0-9]{9}") {
set beresp.do_stream = true;
- if (std.integer(beresp.http.Content-Length, 33554432) >=
33554432 || beresp.http.Content-Length ~ "^[0-9]{9}") {
+ if (std.integer(beresp.http.Content-Length, 50331648) >=
50331648 || beresp.http.Content-Length ~ "^[0-9]{9}") {
// don't attempt to cache these in the frontend
return (hit_for_pass);
}
--
To view, visit https://gerrit.wikimedia.org/r/295443
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0dbfb288a73aaa35f5532a6499d50b1f60ed622b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: BBlack <bbl...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
