Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295756
Change subject: Explicitly depend on mediawiki.util where needed
......................................................................
Explicitly depend on mediawiki.util where needed
Various modules use mw.util without explicitly requesting the
dependency this provides it.
This may lead to JS errors when modules are loaded in certain orders.
Bug: T138473
Change-Id: Ibded5536f49e78d6a9d8e240fb0bf7da3cac4e6d
---
M extension.json
M includes/MobileFrontend.hooks.php
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/56/295756/1
diff --git a/extension.json b/extension.json
index dc29546..fd07cf6 100644
--- a/extension.json
+++ b/extension.json
@@ -439,6 +439,7 @@
],
"dependencies": [
"mobile.modules",
+ "mediawiki.util",
"mediawiki.language",
"mediawiki.jqueryMsg"
],
@@ -603,6 +604,7 @@
"mobile.browser",
"mobile.oo",
"mobile.user",
+ "mediawiki.util",
"mediawiki.api",
"mediawiki.viewport",
"mobile.settings",
@@ -712,6 +714,7 @@
"mobile.drawers",
"mobile.toast",
"mobile.messageBox",
+ "mediawiki.util",
"mediawiki.confirmCloseWindow",
"mobile.loggingSchemas.edit"
],
@@ -769,6 +772,7 @@
"mobile.editor.common",
"mobile.microAutoSize",
"oojs-ui.styles.icons-editing-core",
+ "mediawiki.util",
"mediawiki.notification"
],
"scripts": [
@@ -877,6 +881,7 @@
"desktop"
],
"dependencies": [
+ "mediawiki.util",
"mediawiki.ui.anchor",
"mobile.editor.common"
],
@@ -1064,6 +1069,7 @@
"desktop"
],
"dependencies": [
+ "mediawiki.util",
"mobile.startup"
],
"templates": {
@@ -1399,6 +1405,7 @@
"dependencies": [
"mobile.startup",
"mobile.toast",
+ "mediawiki.util",
"mediawiki.Title"
],
"scripts": [
@@ -1600,6 +1607,7 @@
"desktop"
],
"dependencies": [
+ "mediawiki.util",
"mediawiki.router",
"mobile.startup",
"mobile.mainMenu",
@@ -1658,6 +1666,7 @@
],
"dependencies": [
"skins.minerva.editor",
+ "mediawiki.util",
"mobile.contentOverlays"
],
"scripts": [
@@ -1672,6 +1681,7 @@
"skins.minerva.editor": {
"class": "MFResourceLoaderParsedMessageModule",
"dependencies": [
+ "mediawiki.util",
"mediawiki.router",
"skins.minerva.icons.images.scripts",
"skins.minerva.scripts",
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 05e9c63..41a63c3 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -1119,6 +1119,7 @@
],
'mobile.notifications.overlay' =>
$resourceBoilerplate + [
'dependencies' => [
+ 'mediawiki.util',
'mobile.overlays',
'ext.echo.ui',
],
--
To view, visit https://gerrit.wikimedia.org/r/295756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibded5536f49e78d6a9d8e240fb0bf7da3cac4e6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
