jenkins-bot has submitted this change and it was merged.
Change subject: Don't always update tests.
......................................................................
Don't always update tests.
Change-Id: I5db3aab9240b20797f6cd696f3440bc3b598515f
---
M bin/parserTests.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Arlolra: Looks good to me, approved
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/bin/parserTests.js b/bin/parserTests.js
index 970d074..b0d6624 100755
--- a/bin/parserTests.js
+++ b/bin/parserTests.js
@@ -2152,14 +2152,14 @@
}
// Write updated tests from failed ones
- if (options.hasOwnProperty('update-tests') ||
+ if (options['update-tests'] ||
booleanOption(options['update-unexpected'])) {
var updateFormat = (options['update-tests'] === 'raw') ?
'raw' : 'actualNormalized';
var parserTestsFilename = __dirname +
'/../tests/parserTests.txt';
var parserTests = fs.readFileSync(parserTestsFilename,
'utf8');
this.stats.modes.wt2html.failList.forEach(function(fail) {
- if (booleanOption(options['update-tests'] ||
fail.unexpected)) {
+ if (options['update-tests'] || fail.unexpected)
{
var exp = new RegExp("(" +
/!!\s*test\s*/.source +
Util.escapeRegExp(fail.title) +
/(?:(?!!!\s*end)[\s\S])*/.source +
")(" +
Util.escapeRegExp(fail.expected) + ")", "m");
--
To view, visit https://gerrit.wikimedia.org/r/295772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5db3aab9240b20797f6cd696f3440bc3b598515f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <canan...@wikimedia.org>
Gerrit-Reviewer: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
