Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296230
Change subject: Feed: make sure all client code paths end in a callback
invocation.
......................................................................
Feed: make sure all client code paths end in a callback invocation.
Change-Id: Ie746cb4dba04d7d41f79da701f23dece400bc08e
---
M
app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
M app/src/main/java/org/wikipedia/feed/mostread/MostReadClient.java
2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/30/296230/1
diff --git
a/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
b/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
index 109024d..c4049d5 100644
---
a/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
+++
b/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
@@ -14,6 +14,7 @@
import org.wikipedia.util.DateUtil;
import org.wikipedia.util.log.L;
+import java.io.IOException;
import java.util.Collections;
import java.util.Locale;
@@ -83,6 +84,7 @@
cb.success(Collections.singletonList((Card) tfaCard));
} else {
L.v(response.message());
+ cb.error(new IOException(response.message()));
}
}
diff --git a/app/src/main/java/org/wikipedia/feed/mostread/MostReadClient.java
b/app/src/main/java/org/wikipedia/feed/mostread/MostReadClient.java
index f2aa249..dcf05b1 100644
--- a/app/src/main/java/org/wikipedia/feed/mostread/MostReadClient.java
+++ b/app/src/main/java/org/wikipedia/feed/mostread/MostReadClient.java
@@ -12,6 +12,7 @@
import org.wikipedia.feed.model.Card;
import org.wikipedia.util.log.L;
+import java.io.IOException;
import java.util.Calendar;
import java.util.Collections;
import java.util.List;
@@ -83,11 +84,13 @@
cb.success(cards);
} else {
L.v(response.message());
+ cb.error(new IOException(response.message()));
}
}
@Override public void onFailure(Call<MostReadArticles> call, Throwable
t) {
L.v(t);
+ cb.error(t);
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/296230
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie746cb4dba04d7d41f79da701f23dece400bc08e
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
