Alexandros Kosiaris has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/296379

Change subject: ferm: Remove EXTERNAL_NETWORKS
......................................................................

ferm: Remove EXTERNAL_NETWORKS

The only use of it has been removed from the tree in I74cb2ed6d9b and it
is quite obvious that is was never really useful. Remove it from the
ferm rules

Change-Id: I476dbb0c89a5627bebe01216e5e7cb6d4f23ef01
---
M modules/base/templates/firewall/defs.erb
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/79/296379/1

diff --git a/modules/base/templates/firewall/defs.erb 
b/modules/base/templates/firewall/defs.erb
index 0d1173c..acd6991 100644
--- a/modules/base/templates/firewall/defs.erb
+++ b/modules/base/templates/firewall/defs.erb
@@ -1,5 +1,4 @@
 <%-
-external_networks = scope.lookupvar('network::constants::external_networks')
 networks = scope.lookupvar('network::constants::networks')
 all_networks = scope.lookupvar('network::constants::all_networks')
 all_network_subnets = 
scope.lookupvar('network::constants::all_network_subnets')
@@ -13,7 +12,6 @@
 @def $INTERNAL = (10.0.0.0/8 2620:0:860:100::/56 2620:0:861:100::/56 
2620:0:862:100::/56 2620:0:863:100::/56);
 # $NETWORKS is meant to be a realm dependent set of all networks of a realm.
 @def $NETWORKS = (<%- networks.each do |net| -%><%= net %> <% end -%>);
-@def $EXTERNAL_NETWORKS = (<%- external_networks.each do |external_net| -%><%= 
external_net %> <% end -%>);
 @def $ALL_NETWORKS = (<%- all_networks.each do |net| -%><%= net %> <% end -%>);
 
 # $PRODUCTION_NETWORKS is meant to be a set of all production networks

-- 
To view, visit https://gerrit.wikimedia.org/r/296379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I476dbb0c89a5627bebe01216e5e7cb6d4f23ef01
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to