Ema has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/296408

Change subject: diamond TCP collector: publish TFO-related metrics as gauges
......................................................................

diamond TCP collector: publish TFO-related metrics as gauges

Send TFO-related metrics as gauges instead of counters to work around
what looks like a bug in diamond (T138758).

We added the 'gauges' configuration option to diamond's TCP collector in
version 3.5-6: https://gerrit.wikimedia.org/r/#/c/296380/

Change-Id: Iabc8bec4a61c7793e0a66b6c41cf4321fcc78737
---
M modules/diamond/manifests/init.pp
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/08/296408/1

diff --git a/modules/diamond/manifests/init.pp 
b/modules/diamond/manifests/init.pp
index bb489c1..f717f2f 100644
--- a/modules/diamond/manifests/init.pp
+++ b/modules/diamond/manifests/init.pp
@@ -132,7 +132,13 @@
               'TCPFastOpenPassive', 'TCPFastOpenPassiveFail',
               'TCPFastOpenListenOverflow', 'TCPFastOpenCookieReqd',
               'TCPSynRetrans', 'TCPOrigDataSent'
-            ]
+            ],
+            gauges        => [
+              'CurrEstab', 'MaxConn',
+              'TCPFastOpenActive', 'TCPFastOpenActiveFail',
+              'TCPFastOpenPassive', 'TCPFastOpenPassiveFail',
+              'TCPFastOpenListenOverflow', 'TCPFastOpenCookieReqd'
+            ],
         }
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/296408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabc8bec4a61c7793e0a66b6c41cf4321fcc78737
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to