jenkins-bot has submitted this change and it was merged.
Change subject: Un-break page actions on User pages
......................................................................
Un-break page actions on User pages
Remove the user page specific rule so that page actions styling
can style the heading holder. The change makes sure that there is
enough padding bottom of heading holder for page actions to occupy.
On small screens page actions container is absolutely positioned,
thus it requires space to be reserved.
A downside of this approach is that the space is always reserved even
when the page actions are invisible. This may happen when all page
actions are JS-only and the browser doesn't support JS.
Alternatively, we could introduce a new class for heading holder
which would let us know whether all page actions are JS only or not.
This will allow us to not reserve space for page actions when they
are invisible.
Bug: T137054
Change-Id: Id0dfec608856eca936d4ddbccc56d88bc53888c9
---
M resources/skins.minerva.userpage.styles/userpage.less
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
Phuedx: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/skins.minerva.userpage.styles/userpage.less
b/resources/skins.minerva.userpage.styles/userpage.less
index 118ebc4..779e47c 100755
--- a/resources/skins.minerva.userpage.styles/userpage.less
+++ b/resources/skins.minerva.userpage.styles/userpage.less
@@ -1,10 +1,6 @@
@import 'minerva.variables';
@import 'minerva.mixins';
-.heading-holder {
- padding-bottom: 20px;
-}
-
.tagline {
color: @colorGray5;
font-size: 0.8em;
--
To view, visit https://gerrit.wikimedia.org/r/295775
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0dfec608856eca936d4ddbccc56d88bc53888c9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
