Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296429
Change subject: Report fake API errors with saner error codes
......................................................................
Report fake API errors with saner error codes
In mw.FirefoggTransport, we reported the error code '500' for
something which doesn't even send HTTP requests.
In mw.FormDataTransport, we reported the error code as 'undefined',
because we were reading a non-existent property.
Bug: T138585
Change-Id: I5af26ab7fa9f159cfac0e5d131881b8b5d9ebfb2
---
M resources/transports/mw.FirefoggTransport.js
M resources/transports/mw.FormDataTransport.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/29/296429/1
diff --git a/resources/transports/mw.FirefoggTransport.js
b/resources/transports/mw.FirefoggTransport.js
index 97ffb1c..8b53f61 100644
--- a/resources/transports/mw.FirefoggTransport.js
+++ b/resources/transports/mw.FirefoggTransport.js
@@ -40,7 +40,7 @@
// encoding failed
deferred.reject( {
error: {
- code: 500,
+ code: 'firefogg',
info: 'Encoding failed'
}
} );
diff --git a/resources/transports/mw.FormDataTransport.js
b/resources/transports/mw.FormDataTransport.js
index a19cada..d97fb12 100644
--- a/resources/transports/mw.FormDataTransport.js
+++ b/resources/transports/mw.FormDataTransport.js
@@ -370,7 +370,7 @@
} catch ( e ) {
response = {
error: {
- code: evt.target.code,
+ code: 'parsererror',
info: evt.target.responseText
}
};
--
To view, visit https://gerrit.wikimedia.org/r/296429
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5af26ab7fa9f159cfac0e5d131881b8b5d9ebfb2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
