Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296433
Change subject: Exit with nonzero when qq strings are missing
......................................................................
Exit with nonzero when qq strings are missing
Change-Id: Ife0f114dbe48faa445397aa7a94f74de2309d117
---
M scripts/missing-qq.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/33/296433/1
diff --git a/scripts/missing-qq.py b/scripts/missing-qq.py
index 5f3cecf..4124e9c 100755
--- a/scripts/missing-qq.py
+++ b/scripts/missing-qq.py
@@ -1,5 +1,6 @@
#!/usr/bin/env python
import os
+import sys
import xml.etree.ElementTree as ET
RES_FOLDER = os.path.abspath(os.path.join(os.path.dirname(__file__),
"../app/src/main/res"))
@@ -20,6 +21,10 @@
qqmsgs.add(child.attrib['name'])
# Iterate through all messages and check that they're documented
+missing = 0
for child in enroot:
if child.attrib['name'] not in qqmsgs:
print(child.attrib['name'] + " is undocumented!")
+ missing += 1
+
+sys.exit(1 if missing else 0)
--
To view, visit https://gerrit.wikimedia.org/r/296433
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife0f114dbe48faa445397aa7a94f74de2309d117
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
