Kelson has submitted this change and it was merged. Change subject: Explain that ZIntStream only represents uint32_t values right now. ......................................................................
Explain that ZIntStream only represents uint32_t values right now. Change-Id: Id712847949af1ce32b2e3118fc241be171124186 --- M zimlib/include/zim/zintstream.h 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Kelson: Verified; Looks good to me, approved diff --git a/zimlib/include/zim/zintstream.h b/zimlib/include/zim/zintstream.h index 1c78a1f..66fdfef 100644 --- a/zimlib/include/zim/zintstream.h +++ b/zimlib/include/zim/zintstream.h @@ -41,7 +41,10 @@ substracted from the actual number, so a 2 byte zero is actually a 128. The same logic continues on the 3rd, 4th, ... byte. Up to 7 additional bytes - are used, so the first byte must contain at least one 0. + could used, since the first byte must contain at least one 0. + + This particular implementation only represents uint32_t values (numbers up + to 2^32-1), so it will only ever emit 5 bytes per input value. binary range ------------------------------- -------------------------------------------------- -- To view, visit https://gerrit.wikimedia.org/r/296657 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id712847949af1ce32b2e3118fc241be171124186 Gerrit-PatchSet: 1 Gerrit-Project: openzim Gerrit-Branch: master Gerrit-Owner: Cscott <canan...@wikimedia.org> Gerrit-Reviewer: Kelson <kel...@kiwix.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
