WMDE-leszek has submitted this change and it was merged.
Change subject: Show a tooltip for the questionmark that opens the help text.
......................................................................
Show a tooltip for the questionmark that opens the help text.
Bug: T138945
Change-Id: I6c3235bdf228d051c7039f188ff62d1137377bca
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/ext.RevisionSlider.init.js
4 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
WMDE-leszek: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 3639156..5b93e36 100644
--- a/extension.json
+++ b/extension.json
@@ -45,6 +45,7 @@
],
"messages": [
"revisionslider-show-help",
+ "revisionslider-show-help-tooltip",
"revisionslider-loading-out-of-range",
"revisionslider-loading-failed"
],
diff --git a/i18n/en.json b/i18n/en.json
index 6371657..1929941 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -20,6 +20,7 @@
"revisionslider-arrow-tooltip-newer": "See newer revisions",
"revisionslider-arrow-tooltip-older": "See older revisions",
"revisionslider-show-help": "?",
+ "revisionslider-show-help-tooltip": "Show help text",
"revisionslider-help-dialog-slide1": "The RevisionSlider helps you to
navigate and compare revisions on the diff page. It is based on a
[[m:WMDE_Technical_Wishes/Revision_Slider|community wish]] from the
German-speaking community technical wishlist.",
"revisionslider-help-dialog-slide2": "Each bar represents a page revision.
Bars on the top show growth in size of the page, bars on the bottom show a
reduction. In the image, revision 1 represents added content, while revision 2
represents removal of content.",
"revisionslider-help-dialog-slide3": "<p>To compare certain revisions,
select the revisions using the yellow and blue pointer.</p><p>The blue pointer
controls the newer revision, the yellow pointer maps to the older
revision.</p><p>Move the pointers by drag and drop or click on a bar.</p>",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 8b7fc30..0a1fdc9 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -21,6 +21,7 @@
"revisionslider-arrow-tooltip-newer": "Text shown after hovering the
button scrolling to newer revisions.",
"revisionslider-arrow-tooltip-older": "Text shown after hovering the
button scrolling to older revisions.",
"revisionslider-show-help": "A symbol shown in the \"Show help\"
button.",
+ "revisionslider-show-help-tooltip": "Text shown in a tooltip for the
\"Show help\" button.",
"revisionslider-help-dialog-slide1": "Text shown on the first slide of
the help dialog.",
"revisionslider-help-dialog-slide2": "Text shown on the second slide of
the help dialog.",
"revisionslider-help-dialog-slide3": "Text shown on the third slide of
the help dialog.",
diff --git a/modules/ext.RevisionSlider.init.js
b/modules/ext.RevisionSlider.init.js
index 680dad0..882065f 100644
--- a/modules/ext.RevisionSlider.init.js
+++ b/modules/ext.RevisionSlider.init.js
@@ -37,6 +37,13 @@
} )
.text( mw.message(
'revisionslider-show-help' ).text() )
.addClass( 'mw-show-help' )
+ .tipsy( {
+ gravity: $( 'body'
).hasClass( 'ltr' ) ? 'se' : 'sw',
+ offset: 15,
+ title: function () {
+ return mw.msg(
'revisionslider-show-help-tooltip' );
+ }
+ } )
);
} catch ( err ) {
if ( err === 'RS-rev-out-of-range' ) {
--
To view, visit https://gerrit.wikimedia.org/r/296724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c3235bdf228d051c7039f188ff62d1137377bca
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Jakob <jakob.warkot...@wikimedia.de>
Gerrit-Reviewer: Jakob <jakob.warkot...@wikimedia.de>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
