jenkins-bot has submitted this change and it was merged.
Change subject: MediaWiki theme: Normalize [placeholder] appearance x-browser
and ensure a11y
......................................................................
MediaWiki theme: Normalize [placeholder] appearance x-browser and ensure a11y
Normalizing placeholder appearance across browsers and ensuring accessibility
by providing WCAG 2.0 level AAA color contrast ratio of 7:1.
Bug: T139034
Change-Id: I1c9094ddee538c6cb79cd1e2016debbaae1d1e20
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/widgets.less
2 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Prtksxna: Looks good to me, but someone else must approve
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 3bd5c2f..9229176 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -11,6 +11,7 @@
@color-default-pressed: #444;
@color-default-light: #fff;
@color-emphasized: #000;
+@color-placeholder: #595959; // aligns to WCAG 2.0 level AAA 7:1 contrast ratio
// Primary 'Progressive' and 'Destructive' Colors
@color-progressive: #347bff;
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index e183e9b..bee7fd4 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -625,6 +625,26 @@
}
}
+ // Normalize placeholder styling, see T139034
+ // Firefox 4-18
+ :-moz-placeholder { // stylelint-disable-line
+ color: @color-placeholder;
+ opacity: 1;
+ }
+ // Firefox 19-
+ ::-moz-placeholder { // stylelint-disable-line
+ color: @color-placeholder;
+ opacity: 1;
+ }
+ // Internet Explorer 10-11
+ :-ms-input-placeholder { // stylelint-disable-line
+ color: @color-placeholder;
+ }
+ // WebKit, Blink, Edge
+ ::-webkit-input-placeholder { // stylelint-disable-line
+ color: @color-placeholder;
+ }
+
&.oo-ui-flaggedElement-invalid {
input,
textarea {
--
To view, visit https://gerrit.wikimedia.org/r/296778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c9094ddee538c6cb79cd1e2016debbaae1d1e20
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
