Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296956
Change subject: ApiEchoNotifications: Don't add wikis with no timestamp
......................................................................
ApiEchoNotifications: Don't add wikis with no timestamp
This should prevent fatals in the sort-by-timestamp code
farther down, and also prevent incorrect output.
Bug: T139112
Change-Id: I6480b2e751594ba3392322f40e950f95ae702104
---
M includes/api/ApiEchoNotifications.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/56/296956/1
diff --git a/includes/api/ApiEchoNotifications.php
b/includes/api/ApiEchoNotifications.php
index f343a0a..187f1e1 100644
--- a/includes/api/ApiEchoNotifications.php
+++ b/includes/api/ApiEchoNotifications.php
@@ -346,7 +346,7 @@
}
}
- $wikis = array_keys( $countsByWiki );
+ $wikis = array_keys( $timestampsByWiki );
$count = array_sum( $countsByWiki );
$maxTimestamp = new MWTimestamp( max( $timestampsByWiki
) );
$timestampsByWiki = array_map( function ( $ts ) {
--
To view, visit https://gerrit.wikimedia.org/r/296956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6480b2e751594ba3392322f40e950f95ae702104
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
