Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297120
Change subject: Set 'group' => 'ext.uploadWizard' for all our modules
......................................................................
Set 'group' => 'ext.uploadWizard' for all our modules
This way all of our code will be loaded in a single load.php request,
and no other code will be loaded in the same request. This should
allow us to make some sense out of the line and column numbers for
logged JS errors, and maybe resolve stumpers like T136237.
Previously, we only set that for the 'ext.uploadWizard' module itself,
which was nonsensical. All of the dependencies would load together
with other code, then the final module would load separately.
Bug: T136237
Change-Id: I2d5ee1e4219c260af7d919c9843758e07b600df3
---
M UploadWizard.php
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/20/297120/1
diff --git a/UploadWizard.php b/UploadWizard.php
index 3201e7a..b230804 100644
--- a/UploadWizard.php
+++ b/UploadWizard.php
@@ -91,6 +91,7 @@
$wgHooks['UnitTestsList'][] = 'UploadWizardHooks::onUnitTestsList';
$uploadWizardModuleInfo = [
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__ . '/resources',
'remoteExtPath' => 'UploadWizard/resources',
];
@@ -593,6 +594,7 @@
'scripts' => [
'resources/uw/uw.base.js',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -603,6 +605,7 @@
'dependencies' => [
'uw.base',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -617,6 +620,7 @@
'uw.ui.Deed',
'uw.ui.DeedPreview',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -649,6 +653,7 @@
'mwe-upwiz-copy-location',
'mwe-upwiz-copy-other',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -661,6 +666,7 @@
'oojs',
'uw.controller.base',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -674,6 +680,7 @@
'uw.controller.base',
'uw.ui.Thanks',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -690,6 +697,7 @@
'messages' => [
'mwe-upwiz-prevent-close-wait',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -702,6 +710,7 @@
'uw.controller.Step',
'uw.ui.Upload',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -712,6 +721,7 @@
'dependencies' => [
'uw.base',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -723,6 +733,7 @@
'oojs',
'uw.ui.base',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -735,6 +746,7 @@
'oojs-ui',
'uw.ui.base',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -746,6 +758,7 @@
'oojs',
'uw.ui.Step',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -756,6 +769,7 @@
'dependencies' => [
'uw.ui.base',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -771,6 +785,7 @@
'mwe-upwiz-file-some-failed',
'mwe-upwiz-file-all-failed',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -793,6 +808,7 @@
'mwe-upwiz-objref-notice-update-delay',
'mwe-upwiz-thanks-url',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -814,6 +830,7 @@
'prefs-uploads',
'prefs-upwiz-interface',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
@@ -834,6 +851,7 @@
'mwe-upwiz-file-some-failed',
'mwe-upwiz-file-all-failed',
],
+ 'group' => 'ext.uploadWizard',
'localBasePath' => __DIR__,
'remoteExtPath' => 'UploadWizard',
],
--
To view, visit https://gerrit.wikimedia.org/r/297120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d5ee1e4219c260af7d919c9843758e07b600df3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
