jenkins-bot has submitted this change and it was merged.
Change subject: Provide larger images for news detail view
......................................................................
Provide larger images for news detail view
This adds a flag to getFeedPageListMetadata to allow an endpoint to
request larger, "feature" size image thumb URLs (1024px) rather than
smaller item thumbnail size (320). These can be rewritten downward as
needed by the client.
Change-Id: I725c7c98af8a9f28eaa1e94bca9dc55de468c947
---
M lib/feed/most-read.js
M lib/feed/news.js
M lib/mwapi.js
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/feed/most-read.js b/lib/feed/most-read.js
index 199256c..bc25182 100644
--- a/lib/feed/most-read.js
+++ b/lib/feed/most-read.js
@@ -52,7 +52,7 @@
goodTitles = blacklist.filter(rankedTitles)
.slice(0, mwapi.API_QUERY_MAX_TITLES);
queryTitlesList = constructQueryListFrom(goodTitles);
- return mwapi.getFeedPageListMetadata(app, req,
queryTitlesList.join('|'));
+ return mwapi.getFeedPageListMetadata(app, req,
queryTitlesList.join('|'), false);
}).then(function (response) {
api.checkResponseStatus(response);
diff --git a/lib/feed/news.js b/lib/feed/news.js
index 49da38f..d623f59 100644
--- a/lib/feed/news.js
+++ b/lib/feed/news.js
@@ -71,7 +71,7 @@
story.story = stories[j].innerHTML;
result.payload.push(story);
}
- return mwapi.getFeedPageListMetadata(app, req, linkTitles.join('|'));
+ return mwapi.getFeedPageListMetadata(app, req, linkTitles.join('|'),
true);
}).then(function(response) {
api.checkResponseStatus(response);
diff --git a/lib/mwapi.js b/lib/mwapi.js
index 7a1b113..0fc4aaf 100644
--- a/lib/mwapi.js
+++ b/lib/mwapi.js
@@ -172,7 +172,7 @@
};
}
-function getFeedPageListMetadata(app, req, titlesList) {
+function getFeedPageListMetadata(app, req, titlesList, needFeatureImage) {
var query = {
action: 'query',
format: 'json',
@@ -180,7 +180,7 @@
prop: 'pageimages|pageterms',
piprop: 'thumbnail',
pilimit: API_QUERY_MAX_TITLES,
- pithumbsize: CARD_THUMB_LIST_ITEM_SIZE,
+ pithumbsize: needFeatureImage ? LEAD_IMAGE_XL :
CARD_THUMB_LIST_ITEM_SIZE,
wbptterms: 'description',
meta: 'siteinfo',
siprop: 'general',
--
To view, visit https://gerrit.wikimedia.org/r/296906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I725c7c98af8a9f28eaa1e94bca9dc55de468c947
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org>
Gerrit-Reviewer: GWicke <gwi...@wikimedia.org>
Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
