Hoo man has uploaded a new change for review. https://gerrit.wikimedia.org/r/297338
Change subject: Make getDatatype return nil if property can't be loaded ...................................................................... Make getDatatype return nil if property can't be loaded All known callers can handle that. Bug: T138718 Change-Id: I1c25c99adf1f8f1ee4b15c11439a678b0c4d4e17 --- M includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder refs/changes/38/297338/1 diff --git a/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua b/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua index 6466b7a..3ab52a7 100644 --- a/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua +++ b/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua @@ -14,11 +14,11 @@ local hasReferences = false -- Get the datavalue for a given property. --- @param String propertyId --- @return String datatype +-- @param string propertyId +-- @return string|nil datatype or nil if property couldn't be loaded local getDatatype = function( propertyId ) local property = mw.wikibase.getEntity( propertyId ) - return property['datatype'] + return property and property['datatype'] end ----------------------------------- Implementation of Renderers ----------------------------------- -- To view, visit https://gerrit.wikimedia.org/r/297338 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1c25c99adf1f8f1ee4b15c11439a678b0c4d4e17 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ArticlePlaceholder Gerrit-Branch: master Gerrit-Owner: Hoo man <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
