Muehlenhoff has submitted this change and it was merged.
Change subject: kafka/analytics: Use PRODUCTION_NETWORKS
......................................................................
kafka/analytics: Use PRODUCTION_NETWORKS
Both are only accessed from systems in the production networks.
Change-Id: Ic729853089ffb60a062128b001f53152548a01f7
---
M modules/role/manifests/kafka/analytics/broker.pp
M modules/role/manifests/kafka/analytics/burrow.pp
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Elukey: Looks good to me, but someone else must approve
Muehlenhoff: Verified; Looks good to me, approved
diff --git a/modules/role/manifests/kafka/analytics/broker.pp
b/modules/role/manifests/kafka/analytics/broker.pp
index f29d4fc..70e9f90 100644
--- a/modules/role/manifests/kafka/analytics/broker.pp
+++ b/modules/role/manifests/kafka/analytics/broker.pp
@@ -117,7 +117,7 @@
# TODO: $::confluent::kafka::broker::port doesn't
# seem to work as expected. Hardcoding this for now.
port => 9092,
- srange => '$ALL_NETWORKS',
+ srange => '$PRODUCTION_NETWORKS',
}
include ::ferm::ipsec_allow
diff --git a/modules/role/manifests/kafka/analytics/burrow.pp
b/modules/role/manifests/kafka/analytics/burrow.pp
index 9d918bd..74c0d6f 100644
--- a/modules/role/manifests/kafka/analytics/burrow.pp
+++ b/modules/role/manifests/kafka/analytics/burrow.pp
@@ -22,6 +22,6 @@
ferm::service { 'burrow':
proto => 'tcp',
port => '8000',
- srange => '$ALL_NETWORKS',
+ srange => '$PRODUCTION_NETWORKS',
}
}
--
To view, visit https://gerrit.wikimedia.org/r/295787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic729853089ffb60a062128b001f53152548a01f7
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Elukey <[email protected]>
Gerrit-Reviewer: Joal <[email protected]>
Gerrit-Reviewer: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
