jenkins-bot has submitted this change and it was merged. Change subject: searchInput: Explicitly set the background-color to white ......................................................................
searchInput: Explicitly set the background-color to white When using an OS level dark theme (not a11y related), this search box gets a dark background too. Setting the color explicitly solves this issue. See https://phabricator.wikimedia.org/F4219964 Change-Id: If165660c44d82281dcc7e1713ee9a404541f5b7e --- M dev/wikipedia.org/assets/postcss/_search-box.css M dev/wikipedia.org/assets/postcss/_vars.css 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jdrewniak: Looks good to me, approved jenkins-bot: Verified diff --git a/dev/wikipedia.org/assets/postcss/_search-box.css b/dev/wikipedia.org/assets/postcss/_search-box.css index 2250c7e..b7be40a 100644 --- a/dev/wikipedia.org/assets/postcss/_search-box.css +++ b/dev/wikipedia.org/assets/postcss/_search-box.css @@ -18,6 +18,7 @@ width: 100%; padding-right: 6.4rem; height: 2.7rem; + background: var(--ss-c-white-bg); } .search-container button { diff --git a/dev/wikipedia.org/assets/postcss/_vars.css b/dev/wikipedia.org/assets/postcss/_vars.css index bfa1f31..25de5fd 100644 --- a/dev/wikipedia.org/assets/postcss/_vars.css +++ b/dev/wikipedia.org/assets/postcss/_vars.css @@ -16,6 +16,7 @@ --ss-width: 95px; --ss-height: 24px; + --ss-c-white-bg: #fff; --ss-c-grey: #696969; --ss-c-grey-hover: #f9f9f9; --ss-c-grey-focus: #f0f0f0; -- To view, visit https://gerrit.wikimedia.org/r/296866 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If165660c44d82281dcc7e1713ee9a404541f5b7e Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/portals Gerrit-Branch: master Gerrit-Owner: Prtksxna <[email protected]> Gerrit-Reviewer: JGirault <[email protected]> Gerrit-Reviewer: Jdrewniak <[email protected]> Gerrit-Reviewer: Prtksxna <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
