Alexandros Kosiaris has submitted this change and it was merged.
Change subject: network: fix spec varying based on $::realm
......................................................................
network: fix spec varying based on $::realm
The network::constants class would no more compile due to it now varying
based on $::realm. Ensure the class compile for both known realm
values.
Change-Id: Iaf2ea9e4408bee61ff343ac9148eae6b31bed4f7
---
M modules/network/spec/classes/network_constants_spec.rb
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Alexandros Kosiaris: Verified; Looks good to me, approved
diff --git a/modules/network/spec/classes/network_constants_spec.rb
b/modules/network/spec/classes/network_constants_spec.rb
index 9853f0f..a391365 100644
--- a/modules/network/spec/classes/network_constants_spec.rb
+++ b/modules/network/spec/classes/network_constants_spec.rb
@@ -1,5 +1,12 @@
require 'spec_helper'
describe 'network::constants', :type => :class do
- it { should compile }
+ context "on production" do
+ let(:facts) {{ :realm => 'production' }}
+ it { should compile }
+ end
+ context "on labs" do
+ let(:facts) {{ :realm => 'labs' }}
+ it { should compile }
+ end
end
--
To view, visit https://gerrit.wikimedia.org/r/297381
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf2ea9e4408bee61ff343ac9148eae6b31bed4f7
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
