jenkins-bot has submitted this change and it was merged.
Change subject: Set a fixed max-width to the Special:Notifications page
......................................................................
Set a fixed max-width to the Special:Notifications page
This is to make sure that concatenation of text inside items works
properly given CSS table-layout.
Bug: T138433
Change-Id: Iae32cbf82cdb91880c7ccd7df14d167eb75527cf
---
M modules/echo.variables.less
M modules/styles/mw.echo.ui.DatedSubGroupListWidget.less
M modules/styles/mw.echo.ui.NotificationsInboxWidget.less
3 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Sbisson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/echo.variables.less b/modules/echo.variables.less
index dcb9551..b962f77 100644
--- a/modules/echo.variables.less
+++ b/modules/echo.variables.less
@@ -18,6 +18,8 @@
@specialpage-separation-unit: 0.7em;
@specialpage-sidebar-width: 20em;
+@specialpage-width: 700px;
+
@grey-light: #777;
@grey-medium: #555;
@grey-dark: #333;
diff --git a/modules/styles/mw.echo.ui.DatedSubGroupListWidget.less
b/modules/styles/mw.echo.ui.DatedSubGroupListWidget.less
index 94f5283..6821b31 100644
--- a/modules/styles/mw.echo.ui.DatedSubGroupListWidget.less
+++ b/modules/styles/mw.echo.ui.DatedSubGroupListWidget.less
@@ -1,4 +1,11 @@
+@import '../echo.variables';
.mw-echo-ui-datedSubGroupListWidget {
+ // We have to reiterate the fixed width here so that the
+ // concatenation works inside the items. This is an issue
+ // with css' table-layout, which notification items are
+ // set to
+ max-width: @specialpage-width;
+
&-title {
font-weight: normal;
diff --git a/modules/styles/mw.echo.ui.NotificationsInboxWidget.less
b/modules/styles/mw.echo.ui.NotificationsInboxWidget.less
index 1784d5c..4c10ea0 100644
--- a/modules/styles/mw.echo.ui.NotificationsInboxWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationsInboxWidget.less
@@ -1,5 +1,7 @@
@import '../echo.variables';
.mw-echo-ui-notificationsInboxWidget {
+ max-width: @specialpage-width;
+
&-row {
display: table-row;
width: 100%;
--
To view, visit https://gerrit.wikimedia.org/r/297447
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae32cbf82cdb91880c7ccd7df14d167eb75527cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
