jenkins-bot has submitted this change and it was merged. Change subject: Browser tests for history feature ......................................................................
Browser tests for history feature Bug: T133278 Change-Id: I5ba8d7766e91d733504f488d1f277850e8fab945 --- A tests/browser/features/history.feature M tests/browser/features/support/step_definitions/common_steps.rb 2 files changed, 35 insertions(+), 0 deletions(-) Approvals: WMDE-Fisch: Verified; Looks good to me, approved WMDE-leszek: Checked jenkins-bot: Verified diff --git a/tests/browser/features/history.feature b/tests/browser/features/history.feature new file mode 100644 index 0000000..e0a74c7 --- /dev/null +++ b/tests/browser/features/history.feature @@ -0,0 +1,27 @@ +@chrome @en.wikipedia.beta.wmflabs.org @firefox @integration +Feature: RevisionSlider history + Background: + Given I am logged in + And I have reset my preferences + And RevisionSlider is enabled as a beta feature + And a page with 4 revision(s) exists + And I am on the diff page + And The RevisionSlider has loaded + And I have closed the help dialog at the start + And The help dialog is hidden + And I click on revision 1 + And the darkness has faded + + Scenario: RevisionSlider history can be accessed using browser back and forward buttons + Given I click the browser back button + And the darkness has faded + Then the lower pointer should be on revision 3 + And the lower pointer should be on revision 4 + And revision 3 should be loaded on the left of the diff + And revision 4 should be loaded on the right of the diff + Given I click the browser forward button + And the darkness has faded + Then the lower pointer should be on revision 1 + And the lower pointer should be on revision 4 + And revision 1 should be loaded on the left of the diff + And revision 4 should be loaded on the right of the diff \ No newline at end of file diff --git a/tests/browser/features/support/step_definitions/common_steps.rb b/tests/browser/features/support/step_definitions/common_steps.rb index b6fc26f..8b6ea53 100644 --- a/tests/browser/features/support/step_definitions/common_steps.rb +++ b/tests/browser/features/support/step_definitions/common_steps.rb @@ -18,6 +18,14 @@ end end +When(/^I click the browser back button$/) do + on(ArticlePage).back +end + +When(/^I click the browser forward button$/) do + on(ArticlePage).forward +end + Given(/^The RevisionSlider has loaded$/) do on(DiffPage).wait_for_slider_to_load end -- To view, visit https://gerrit.wikimedia.org/r/297402 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ba8d7766e91d733504f488d1f277850e8fab945 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/RevisionSlider Gerrit-Branch: master Gerrit-Owner: Addshore <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Gabriel Birke <[email protected]> Gerrit-Reviewer: Jakob <[email protected]> Gerrit-Reviewer: Kai Nissen (WMDE) <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> Gerrit-Reviewer: WMDE-Fisch <[email protected]> Gerrit-Reviewer: WMDE-leszek <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
