Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297620
Change subject: Pad Feed cards not the RecyclerView
......................................................................
Pad Feed cards not the RecyclerView
When swiped left or right, Feed cards are truncated by the padding of
the parent RecyclerView. Move the padding from the RecyclerView to the
card ItemDecoration. This gives a better full screen experience and
makes the cards feel like their falling on the ground.
Change-Id: Iec1bf40a4b18ba3b4b7d460c802a660823e424b2
---
M app/src/main/res/layout/fragment_feed.xml
M app/src/main/res/values/dimens.xml
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/20/297620/1
diff --git a/app/src/main/res/layout/fragment_feed.xml
b/app/src/main/res/layout/fragment_feed.xml
index 58f9d13..bd14c15 100644
--- a/app/src/main/res/layout/fragment_feed.xml
+++ b/app/src/main/res/layout/fragment_feed.xml
@@ -56,8 +56,6 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:scrollbars="vertical"
- android:paddingLeft="@dimen/view_list_card_margin_horizontal"
- android:paddingRight="@dimen/view_list_card_margin_horizontal"
app:behavior_overlapTop="100dp"
app:layout_behavior="@string/appbar_scrolling_view_behavior"
app:minColumnWidth="@dimen/view_feed_min_column_width"/>
diff --git a/app/src/main/res/values/dimens.xml
b/app/src/main/res/values/dimens.xml
index 7fc75a3..37db905 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -95,7 +95,7 @@
<dimen name="view_feed_header_height">260dp</dimen>
<dimen name="view_feed_min_column_width">229.3dp</dimen>
<dimen name="view_list_card_margin_vertical">8dp</dimen>
- <dimen name="view_list_card_margin_horizontal">5.3dp</dimen>
+ <dimen name="view_list_card_margin_horizontal">10.6dp</dimen>
<dimen name="view_list_card_item_margin">16dp</dimen>
<dimen
name="view_horizontal_scrolling_list_card_item_margin_horizontal">4dp</dimen>
<dimen
name="view_horizontal_scrolling_list_card_item_margin_vertical">0dp</dimen>
--
To view, visit https://gerrit.wikimedia.org/r/297620
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec1bf40a4b18ba3b4b7d460c802a660823e424b2
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
