jenkins-bot has submitted this change and it was merged.
Change subject: Make gallery dialog caption field multiline
......................................................................
Make gallery dialog caption field multiline
Also change remove button label from "Remove" to "Remove image".
Bug: T139421
Bug: T137982
Change-Id: I1b11eb44c672bad0d53d139d66e796a0657457f5
---
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
3 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 7f6f062..8dfe99d 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -281,7 +281,7 @@
"visualeditor-mwgallerydialog-mode-dropdown-label-packed-overlay":
"Packed with overlaid captions",
"visualeditor-mwgallerydialog-mode-dropdown-label-traditional":
"Traditional",
"visualeditor-mwgallerydialog-mode-field-label": "Display mode",
- "visualeditor-mwgallerydialog-remove-button-label": "Remove",
+ "visualeditor-mwgallerydialog-remove-button-label": "Remove image",
"visualeditor-mwgallerydialog-perrow-field-label": "Images per row",
"visualeditor-mwgallerydialog-search-button-label": "Add new image",
"visualeditor-mwgallerydialog-styles-field-label": "CSS styles",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index 44aca9b..54d1b25 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -292,7 +292,7 @@
"visualeditor-mwgallerydialog-mode-dropdown-label-packed-overlay":
"Label for the packed-overlay option in the mode dropdown of the gallery
dialog",
"visualeditor-mwgallerydialog-mode-dropdown-label-traditional": "Label
for the traditional option in the mode dropdown of the gallery dialog",
"visualeditor-mwgallerydialog-mode-field-label": "Label for the mode
field of the gallery dialog",
- "visualeditor-mwgallerydialog-remove-button-label": "Label for the
remove button of the gallery dialog\n{{Identical|Remove}}",
+ "visualeditor-mwgallerydialog-remove-button-label": "Label for the
remove image button of the gallery dialog\n{{Identical|Remove}}",
"visualeditor-mwgallerydialog-perrow-field-label": "Label for the
perrow field of the gallery dialog",
"visualeditor-mwgallerydialog-search-button-label": "Label for the show
search panel button of the gallery dialog",
"visualeditor-mwgallerydialog-styles-field-label": "Label for the
styles field of the gallery dialog",
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
index fb5c94f..9499d06 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
@@ -107,7 +107,9 @@
.addClass( 've-ui-mwGalleryDialog-highlighted-image' );
// TODO: make into a ve.ui.MWTargetWidget once Parsoid handles galleries
this.highlightedCaptionInput = new OO.ui.TextInputWidget( {
- placeholder: 'Image caption'
+ placeholder: 'Image caption',
+ multiline: true,
+ autosize: true
} );
this.removeButton = new OO.ui.ButtonWidget( {
label: ve.msg(
'visualeditor-mwgallerydialog-remove-button-label' ),
--
To view, visit https://gerrit.wikimedia.org/r/297612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b11eb44c672bad0d53d139d66e796a0657457f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders <thalia.e.c...@googlemail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
