jenkins-bot has submitted this change and it was merged.
Change subject: Ensure getNodesByType always returns an array
......................................................................
Ensure getNodesByType always returns an array
Change-Id: Idedb5cb7cc9d202204ef33d0b63cabd1bb274510
---
M src/dm/ve.dm.Document.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
DLynch: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/src/dm/ve.dm.Document.js b/src/dm/ve.dm.Document.js
index 8b34f45..6507a13 100644
--- a/src/dm/ve.dm.Document.js
+++ b/src/dm/ve.dm.Document.js
@@ -1050,7 +1050,7 @@
}
}
} else {
- nodes = this.nodesByType[ type ];
+ nodes = this.nodesByType[ type ] || [];
}
if ( sort ) {
--
To view, visit https://gerrit.wikimedia.org/r/297805
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idedb5cb7cc9d202204ef33d0b63cabd1bb274510
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: DLynch <[email protected]>
Gerrit-Reviewer: Divec <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
