jenkins-bot has submitted this change and it was merged.
Change subject: Followup Ib7f4dc4ea: Bring back message tooltip with 'notice'
text
......................................................................
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text
The message for tooltip-pt-notifications-message was removed to comply
with the new naming. The problem is that in the back end, sections are
still defined as 'message' vs 'alerts' and the sections in the user
toolbar are defined with those terms. In no-JS mode (which is before
the user clicks any of the badges) this tooltip is created automatically
by MediaWiki based on class names.
It's easier to return the message key with different text for translation
and wait for the bigger tech debt to correct all instances of 'message'
to 'notice' (including in the API, which would require a much more
massive work)
Bug: T139520
Change-Id: I6368b63e38f64aa065f2580df812de1c63a93716
---
M i18n/en.json
M i18n/qqq.json
M modules/ui/mw.echo.ui.NotificationBadgeWidget.js
3 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/en.json b/i18n/en.json
index 1cc1e95..998b93b 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -80,6 +80,7 @@
"notifications": "Notifications",
"tooltip-pt-notifications-alert": "{{GENDER:|Your}} alerts",
"tooltip-pt-notifications-notice": "{{GENDER:|Your}} notices",
+ "tooltip-pt-notifications-message": "{{GENDER:|Your}} notices",
"echo-displaynotificationsconfiguration": "Display Notifications
configuration",
"echo-displaynotificationsconfiguration-summary": "This is an overview
of how Notifications are configured on this wiki.",
"echo-displaynotificationsconfiguration-notifications-by-category-header":
"Notifications by category",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index afd3436..2f8ad31 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -71,6 +71,7 @@
"notifications":
"{{doc-special|Notifications}}\n{{Identical|Notification}}",
"tooltip-pt-notifications-alert": "This is used for the title
(mouseover text) of the alert notifications user tool.",
"tooltip-pt-notifications-notice": "This is used for the title
(mouseover text) of the notice notifications user tool.",
+ "tooltip-pt-notifications-message": "This is used for the title
(mouseover text) of the notice notifications user tool.",
"echo-displaynotificationsconfiguration":
"{{doc-special|DisplayNotificationsConfiguration}}\n\nThis could be rephrased
as \"Display the configuration of Notifications\".",
"echo-displaynotificationsconfiguration-summary": "Summary of the
DisplayNotificationsConfiguration special page",
"echo-displaynotificationsconfiguration-notifications-by-category-header":
"Header on DisplayNotificationsConfiguration for a list of which notifications
are in each category",
diff --git a/modules/ui/mw.echo.ui.NotificationBadgeWidget.js
b/modules/ui/mw.echo.ui.NotificationBadgeWidget.js
index c0619c7..ee921d9 100644
--- a/modules/ui/mw.echo.ui.NotificationBadgeWidget.js
+++ b/modules/ui/mw.echo.ui.NotificationBadgeWidget.js
@@ -71,7 +71,9 @@
// tooltip-pt-notifications-alert
// tooltip-pt-notifications-notice
title: mw.msg( 'tooltip-pt-notifications-' +
- this.controller.getTypeString() === 'message' ?
'notice' : this.controller.getTypeString()
+ (
+ this.controller.getTypeString() ===
'message' ? 'notice' : this.controller.getTypeString()
+ )
),
href: config.href
} );
--
To view, visit https://gerrit.wikimedia.org/r/297932
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6368b63e38f64aa065f2580df812de1c63a93716
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
