jenkins-bot has submitted this change and it was merged.
Change subject: Tweaks to settings page
......................................................................
Tweaks to settings page
* Change labels in English for settings options
* Update description for enable option
* Remove description for disable option
Bug: T138233
Change-Id: Id23dcc7b7e655f7939bb2e455b8680ed5a2c6331
---
M Popups.hooks.php
M i18n/en.json
M i18n/qqq.json
M resources/ext.popups.settings.js
4 files changed, 4 insertions(+), 8 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Popups.hooks.php b/Popups.hooks.php
index c81db91..9144cd2 100644
--- a/Popups.hooks.php
+++ b/Popups.hooks.php
@@ -108,7 +108,6 @@
"popups-settings-option-advanced",
"popups-settings-option-advanced-description",
"popups-settings-option-off",
- "popups-settings-option-off-description",
"popups-settings-save",
"popups-settings-cancel",
"popups-settings-enable",
diff --git a/i18n/en.json b/i18n/en.json
index 4a83ce1..dd1e2b2 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -8,12 +8,11 @@
"popups-redirects": "redirects to <h3>$1</h3>",
"popups-settings-title": "Page preview",
"popups-settings-description": "This tool lets you preview links to
wiki pages and to references.",
- "popups-settings-option-simple": "Simple",
- "popups-settings-option-simple-description": "See the lead sentence of
a page and a preview image. This is recommended for readers.",
+ "popups-settings-option-simple": "Enable",
+ "popups-settings-option-simple-description": "Get quick previews of a
topic while reading an article.",
"popups-settings-option-advanced": "Advanced",
"popups-settings-option-advanced-description": "See link previews and
access editing function menus. This is used by many editors.",
- "popups-settings-option-off": "Disable previews",
- "popups-settings-option-off-description": "You can change this setting
using the link in the footer of the page.",
+ "popups-settings-option-off": "Disable",
"popups-settings-save": "Save",
"popups-settings-help-ok": "OK",
"popups-settings-cancel": "Cancel",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index b1976f5..1942c75 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -19,7 +19,6 @@
"popups-settings-option-advanced": "Title for the editor or navigation
popups option\n{{Identical|Advanced}}",
"popups-settings-option-advanced-description": "Description for the
editor or navigation popups option",
"popups-settings-option-off": "Title to turn off hovercards
option.\n\nSee also:\n* {{msg-mw|Popups-settings-enable}}",
- "popups-settings-option-off-description": "Description for turn off
hovercards option",
"popups-settings-save": "Save buttton for the setting's
dialoag\n{{Identical|Save}}",
"popups-settings-help-ok": "Label of a button",
"popups-settings-cancel": "Cancel button for the setting's
dialog\n{{Identical|Cancel}}",
diff --git a/resources/ext.popups.settings.js b/resources/ext.popups.settings.js
index 85ebea3..8dcb48d 100644
--- a/resources/ext.popups.settings.js
+++ b/resources/ext.popups.settings.js
@@ -37,8 +37,7 @@
},
{
id: 'off',
- name: mw.message(
'popups-settings-option-off' ).text(),
- description: mw.message(
'popups-settings-option-off-description' ).text()
+ name: mw.message(
'popups-settings-option-off' ).text()
}
];
--
To view, visit https://gerrit.wikimedia.org/r/297632
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id23dcc7b7e655f7939bb2e455b8680ed5a2c6331
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
