Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298007
Change subject: Don't use deprecated definition of SpecialPage in
$wgSpecialPages
......................................................................
Don't use deprecated definition of SpecialPage in $wgSpecialPages
Array syntax for $wgSpecialPages is deprecated since 1.18. Converted
SpecialAboutTopic to use the constructor instead.
Change-Id: I7381f68d72ae0337daa199c5948fbfe7693ffc82
---
M extension.json
M includes/SpecialAboutTopic.php
2 files changed, 11 insertions(+), 33 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/07/298007/1
diff --git a/extension.json b/extension.json
index 10e0fcc..5042d35 100644
--- a/extension.json
+++ b/extension.json
@@ -8,10 +8,7 @@
"type": "other",
"license-name": "GPL-2.0+",
"SpecialPages": {
- "AboutTopic": [
- "ArticlePlaceholder\\SpecialAboutTopic",
- "newFromGlobalState"
- ]
+ "AboutTopic": "ArticlePlaceholder\\SpecialAboutTopic"
},
"MessagesDirs": {
"ArticlePlaceholder": [
diff --git a/includes/SpecialAboutTopic.php b/includes/SpecialAboutTopic.php
index 8b6247b..53b0b26 100644
--- a/includes/SpecialAboutTopic.php
+++ b/includes/SpecialAboutTopic.php
@@ -25,19 +25,6 @@
*/
class SpecialAboutTopic extends SpecialPage {
- public static function newFromGlobalState() {
- $wikibaseClient = WikibaseClient::getDefaultInstance();
- return new self(
- $wikibaseClient->getEntityIdParser(),
-
$wikibaseClient->getLanguageFallbackLabelDescriptionLookupFactory(),
- $wikibaseClient->getStore()->getSiteLinkLookup(),
- $wikibaseClient->getSiteStore(),
- new TitleFactory(),
- $wikibaseClient->getSettings()->getSetting(
'siteGlobalID' ),
- $wikibaseClient->getStore()->getEntityLookup()
- );
- }
-
/**
* @var EntityIdParser
*/
@@ -76,22 +63,16 @@
/**
* Initialize the special page.
*/
- public function __construct(
- EntityIdParser $idParser,
- LanguageFallbackLabelDescriptionLookupFactory
$termLookupFactory,
- SiteLinkLookup $sitelinkLookup,
- SiteStore $siteStore,
- TitleFactory $titleFactory,
- $siteGlobalID,
- EntityLookup $entityLookup
- ) {
- $this->idParser = $idParser;
- $this->termLookupFactory = $termLookupFactory;
- $this->sitelinkLookup = $sitelinkLookup;
- $this->siteStore = $siteStore;
- $this->titleFactory = $titleFactory;
- $this->siteGlobalID = $siteGlobalID;
- $this->entityLookup = $entityLookup;
+ public function __construct() {
+ $wikibaseClient = WikibaseClient::getDefaultInstance();
+
+ $this->idParser = $wikibaseClient->getEntityIdParser();
+ $this->termLookupFactory =
$wikibaseClient->getLanguageFallbackLabelDescriptionLookupFactory();
+ $this->sitelinkLookup =
$wikibaseClient->getStore()->getSiteLinkLookup();
+ $this->siteStore = $wikibaseClient->getSiteStore();
+ $this->titleFactory = new TitleFactory();
+ $this->siteGlobalID =
$wikibaseClient->getSettings()->getSetting( 'siteGlobalID' );
+ $this->entityLookup =
$wikibaseClient->getStore()->getEntityLookup();
parent::__construct( 'AboutTopic' );
}
--
To view, visit https://gerrit.wikimedia.org/r/298007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7381f68d72ae0337daa199c5948fbfe7693ffc82
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
