jenkins-bot has submitted this change and it was merged.
Change subject: Add aria-hidden to several Layouts
......................................................................
Add aria-hidden to several Layouts
Bug: T129791
Bug: T129792
Change-Id: I2bc42dd85abe5aeaa7743f4b9e194d3d5e477e9d
---
M src/layouts/MenuLayout.js
M src/layouts/StackLayout.js
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
VolkerE: Looks good to me, but someone else must approve
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/layouts/MenuLayout.js b/src/layouts/MenuLayout.js
index 5d3d00a..0b6a6d6 100644
--- a/src/layouts/MenuLayout.js
+++ b/src/layouts/MenuLayout.js
@@ -117,6 +117,7 @@
this.$element
.toggleClass( 'oo-ui-menuLayout-showMenu',
this.showMenu )
.toggleClass( 'oo-ui-menuLayout-hideMenu',
!this.showMenu );
+ this.$menu.attr( 'aria-hidden', this.showMenu ? 'false' :
'true' );
}
return this;
diff --git a/src/layouts/StackLayout.js b/src/layouts/StackLayout.js
index 3951eeb..35a15dd 100644
--- a/src/layouts/StackLayout.js
+++ b/src/layouts/StackLayout.js
@@ -264,10 +264,12 @@
for ( i = 0, len = items.length; i < len; i++ ) {
if ( !selectedItem || selectedItem !== items[ i ] ) {
items[ i ].$element.addClass(
'oo-ui-element-hidden' );
+ items[ i ].$element.attr( 'aria-hidden', 'true'
);
}
}
if ( selectedItem ) {
selectedItem.$element.removeClass(
'oo-ui-element-hidden' );
+ selectedItem.$element.removeAttr( 'aria-hidden' );
}
}
};
--
To view, visit https://gerrit.wikimedia.org/r/297426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bc42dd85abe5aeaa7743f4b9e194d3d5e477e9d
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
Gerrit-Reviewer: DLynch <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
