Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298455
Change subject: Take status of pod into account as well for webservice status
......................................................................
Take status of pod into account as well for webservice status
Change-Id: Ia035e5ec59e3f72976af83722fd70a56554c551f
---
M toollabs/webservice/backends/kubernetesbackend.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/operations/software/tools-webservice
refs/changes/55/298455/1
diff --git a/toollabs/webservice/backends/kubernetesbackend.py
b/toollabs/webservice/backends/kubernetesbackend.py
index a1f8cd8..3b9110c 100644
--- a/toollabs/webservice/backends/kubernetesbackend.py
+++ b/toollabs/webservice/backends/kubernetesbackend.py
@@ -234,8 +234,11 @@
def get_state(self):
if self._find_obj(pykube.Service, self.label_selector) is not None\
and self._find_obj(pykube.Deployment, self.label_selector) is
not None:
- # FIXME: Check if pod is running as well
- return Backend.STATE_RUNNING
+ pod = self._find_obj(pykube.Pod, self.label_selector)
+ if pod:
+ if pod.obj['status']['phase'] == 'Running':
+ return Backend.STATE_RUNNING
+ return Backend.STATE_PENDING
return Backend.STATE_STOPPED
def _wait_for_pod(self, label_selector, timeout=30):
--
To view, visit https://gerrit.wikimedia.org/r/298455
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia035e5ec59e3f72976af83722fd70a56554c551f
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/tools-webservice
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
