jenkins-bot has submitted this change and it was merged.
Change subject: Adjust feed layout dimensions
......................................................................
Adjust feed layout dimensions
* Increase the minimum width. On a Nexus 9 in portrait mode the feed has three
columns,
which are too narrow, to the point that headline text gets clipped. In
landscape mode it
still has three columns, but there it's ok. Tested also on a Nexus 5.
* Reduce horizontal margin because the space between two columns was too wide.
* Increase vertical margin because sometime it's harder to see where a new card
starts.
Change-Id: Ibfce7c8edc1d4ca5f5b0534eb0e12a199d6cdb36
---
M app/src/main/res/values/dimens.xml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Mholloway: Looks good to me, but someone else must approve
Dbrant: Looks good to me, approved
Niedzielski: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/app/src/main/res/values/dimens.xml
b/app/src/main/res/values/dimens.xml
index 0a83ae9..03b8355 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -94,9 +94,9 @@
<!-- The Feed -->
<dimen name="view_feed_header_height">232dp</dimen>
<dimen name="view_feed_overlap_top">84dp</dimen>
- <dimen name="view_feed_min_column_width">229.3dp</dimen>
- <dimen name="view_list_card_margin_vertical">4dp</dimen>
- <dimen name="view_list_card_margin_horizontal">10.6dp</dimen>
+ <dimen name="view_feed_min_column_width">320dp</dimen>
+ <dimen name="view_list_card_margin_vertical">5dp</dimen>
+ <dimen name="view_list_card_margin_horizontal">7dp</dimen>
<dimen name="view_list_card_item_margin">16dp</dimen>
<dimen
name="view_horizontal_scrolling_list_card_item_margin_horizontal">4dp</dimen>
<dimen
name="view_horizontal_scrolling_list_card_item_margin_vertical">0dp</dimen>
--
To view, visit https://gerrit.wikimedia.org/r/298246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfce7c8edc1d4ca5f5b0534eb0e12a199d6cdb36
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
