WMDE-leszek has submitted this change and it was merged.
Change subject: Account for suppressed comments and users
......................................................................
Account for suppressed comments and users
Bug: T140397
Change-Id: Ie3a4d81da38f6b721c80738d725fc59cc4fec345
---
M modules/ext.RevisionSlider.Revision.js
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
WMDE-leszek: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.Revision.js
b/modules/ext.RevisionSlider.Revision.js
index 2bbc78d..bd8cc10 100644
--- a/modules/ext.RevisionSlider.Revision.js
+++ b/modules/ext.RevisionSlider.Revision.js
@@ -7,11 +7,19 @@
var Revision = function ( data ) {
this.id = data.revid;
this.size = data.size;
- this.comment = data.comment;
- this.parsedComment = data.parsedcomment;
this.timestamp = data.timestamp;
- this.user = data.user;
this.minor = data.hasOwnProperty( 'minor' ) && ( data.minor ||
data.minor === '' );
+
+ // Comments and users can be suppressed thus we must check if
they exist
+ if ( typeof data.comment !== 'undefined' ) {
+ this.comment = data.comment;
+ }
+ if ( typeof data.parsedcomment !== 'undefined' ) {
+ this.parsedComment = data.parsedcomment;
+ }
+ if ( typeof data.user !== 'undefined' ) {
+ this.user = data.user;
+ }
};
$.extend( Revision.prototype, {
--
To view, visit https://gerrit.wikimedia.org/r/299041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3a4d81da38f6b721c80738d725fc59cc4fec345
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Jakob <jakob.warkot...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.fisc...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
